Repository navigation
fix(desktop): key the change list on the channel, not the updater channel - #121
Merged
Merged
Conversation
…nnel The change list shipped empty. The previous-build lookup matched on the brand's `updateChannel`, which is already `staging-nightly`, so it searched tags for `-staging-nightly-nightly.`, found nothing, and returned no commits — and because the change list is deliberately never fatal, the release published quietly without it. Confirmed on v0.0.34-staging-nightly.20260819.1, built from the commit that introduced it. Key on the channel instead, the same predicate the workflow's already-published check uses, and move the lookup into a tested function. The first version tested the summariser and left the lookup inline and uncovered, which is exactly where the bug was. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #120, which shipped the change list broken.
What happened
v0.0.34-staging-nightly.20260819.1was built from the commit that added the change list, and published with no "What changed" section.The previous-build lookup matched on the brand's
updateChannel. That value is alreadystaging-nightly, so the predicate searched tags for-staging-nightly-nightly.— a shape that does not exist. No previous tag, no commits, empty list.It failed silently by design: the change list is deliberately never fatal, because a release that does not ship is an outage of the update channel while a release missing its notes is cosmetic. That was the right call and it is also what hid this — the release published normally and simply said nothing.
The fix
Key on the channel (
staging/production), which is the same predicate the workflow's own already-published check uses:The lookup moves into
findPreviousChannelTagand is now covered. #120 tested the summariser and left this seam inline and untested — which is precisely where the bug was. The new tests use the real tag shapes, including one asserting a staging build never picks up the production channel's tag.Verification
11 tests passed,tsgo --noEmitclean forscripts(0 errors), lint passes.Merging this to
expbkmaintriggers the next staging release, whose body is the real proof — I'll check it rather than assume.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.