Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Function Not Work In WFS #16

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

mrzh4s
Copy link
Contributor

@mrzh4s mrzh4s commented Mar 3, 2023

Fix WFS style function not call each feature style and some updating version of WFS & WMS.

Copy link
Owner

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mrzh4s for your PR. I have added few comments. Please kindly respond.

"requires": true,
"packages": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is not necessary, can you please revert back this file to original form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely.

src/L.Geoserver.js Outdated Show resolved Hide resolved
src/L.Geoserver.js Show resolved Hide resolved
@mrzh4s
Copy link
Contributor Author

mrzh4s commented Mar 5, 2023

updating some code and do your request.

@mrzh4s
Copy link
Contributor Author

mrzh4s commented Mar 5, 2023

image

prove script work correctly for calling style in wfs and version selection

@mrzh4s
Copy link
Contributor Author

mrzh4s commented Mar 5, 2023

suggestion for filtering. name from CQL_FILTER to filter for more approachable script. 😊

Copy link
Owner

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iamtekson
Copy link
Owner

suggestion for filtering. name from CQL_FILTER to filter for more approachable script. 😊

In geoserver filter, we use CQL_FILTER as a parameter name. So I think we can leave it as it is.

@iamtekson iamtekson merged commit 1184630 into iamtekson:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants