Fix configuration for eslint (linting subdirectories; activating jest rules #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1926 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 175 181 +6
Lines 1697 2064 +367
Branches 387 538 +151
==========================================
+ Hits 1697 2064 +367
Continue to review full report at Codecov.
|
iamkun
reviewed
Jun 11, 2022
| @@ -139,16 +139,7 @@ describe('Clone', () => { | |||
| }) | |||
|
|
|||
| describe('Milliseconds', () => { | |||
| expect(dayjs.duration(500).milliseconds()).toBe(500) | |||
There was a problem hiding this comment.
this PR is a little confused to me.
Is these unit cases modification not relevant to this PR, or coming from some of your other PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration for eslint had 2 minor topics:
Fixes these topics and removed the newly identified warnings.