Include Google and Twitter SVGs #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also very keen on getting SVG's any reason this isnt merged? |
|
No one has ever responded... |
|
@iamcal Any reason why this cant be merged? |
|
Sorry for not responding sooner - The Apple emoji font uses bitmaps, not vectors/SVG, so there's no way to get SVGs for either Apple or Facebook images. As a result, I don't think it makes sense for this library to include SVG images. The purpose of this library is to make it easy to use bitmap'd emoji from the various icon sets, either as sheets or as individual images. If you want to use the SVGs from either Twemoji or Noto, then you can just use them directly from those projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I commented in #174 I'd like some larger emoji images (I'm rendering some 78px emojis in some places and with a retina display, that requires 156px).
I noticed that once we get up to pngs that large, the SVGs are actually smaller. I notices that Google and Twitter provide SVG so I modified two scripts to collect them into this repository:
build/google/makeSvg.shandbuild/twitter/grab.php.Note: First time ever using PHP
I don't know much about TTC fonts, but ideally we could extract Apple SVGs as well. Any ideas how to do that?
Also, it might make sense to integrate these in the build pipeline for
emoji-datasource-googleandemoji-datasource-twitter.Thanks!