Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use loader mechanism to detect presence of loader #180

Merged

Conversation

iambumblehead
Copy link
Owner

@koshic please review.

I appreciate your help and it would be really awesome if your name appeared in the contributors list at the main github page. If you wanted to copy these changes or use another approach in a different PR you make, I would merge your PR instead.

Whatever you want to do, either way thank you

src/esmockIsLoader.js Outdated Show resolved Hide resolved
src/esmock.js Show resolved Hide resolved
src/esmockLoader.js Outdated Show resolved Hide resolved
@koshic
Copy link
Collaborator

koshic commented Oct 19, 2022

I appreciate your help and it would be really awesome if your name appeared in the contributors list at the main github page. If you wanted to copy these changes or use another approach in a different PR you make, I would merge your PR instead.

Thank you! But this is unnecessary. Open source for me is about collaboration, not badges / achievements / co-authoring in titles )

@iambumblehead
Copy link
Owner Author

I'm interested to make other changes needed to remove dependencies for yarn PnP but will be busy until tomorrow maybe. Thanks for the valuable input and discussion.

@koshic
Copy link
Collaborator

koshic commented Oct 19, 2022

I'm interested to make other changes needed to remove dependencies for yarn PnP but will be busy until tomorrow maybe. Thanks for the valuable input and discussion.

Ok, and I can check new version of esmock in my setup if you publish it today.

@iambumblehead
Copy link
Owner Author

closes #178

@iambumblehead iambumblehead merged commit 13b688b into master Oct 20, 2022
@iambumblehead iambumblehead deleted the use-loader-mechanism-to-detect-presence-of-loader branch October 20, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants