feat: implemented CI #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughNew configuration and documentation files have been added to the repository. These include a GitHub Actions workflow for CI/CD automation, a Dockerfile for containerizing a Go application, a README for AWS CLI v2 installation in Kubernetes manifests, and a comprehensive third-party licenses file. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub
participant CI Workflow
participant DockerHub
participant Repository
Developer->>GitHub: Push to main branch
GitHub->>CI Workflow: Trigger workflow
CI Workflow->>CI Workflow: build job (build & test Go app)
CI Workflow->>CI Workflow: code-quality job (lint)
CI Workflow->>CI Workflow: push job (after build)
CI Workflow->>DockerHub: Build & push Docker image
CI Workflow->>CI Workflow: update-newtag-in-helm-chart job (after push)
CI Workflow->>Repository: Update Helm chart with new image tag
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
Dockerfile (1)
20-22: Add reproducible, statically-linked build flagsFor Go containers, it’s common to pin the GOOS/GOARCH and disable CGO so the binary is fully static and runs happily in the distroless stage (which lacks libc).
-RUN go build -o main . +ENV CGO_ENABLED=0 \ + GOOS=linux \ + GOARCH=amd64 +RUN go build -ldflags="-s -w" -o /main .This shaves a few MB off the image and avoids runtime surprises on alpine/distroless bases.
k8s/manifests/aws/README.md (1)
7-55: Specify a language for fenced code blocks & drop superfluous$prompts
markdownlintflags every block asMD040/MD014.-``` -$ sudo ./install +```bash +sudo ./install ... -``` +```Apply the same
bash(orshell) marker and remove the leading$in all command snippets (lines 14-16, 24-32, 39-41, 47-51). This keeps the docs linter-clean and lets GitHub render syntax highlighting..github/workflow/ci.yaml (1)
30-34: Strip trailing whitespace & keep the YAML linter quietThere are two lines with stray spaces (30 & 46).
- run: go build -o go-web-app + run: go build -o go-web-app ... - version: v1.56.2 + version: v1.56.2A tiny clean-up, but it silences
yamllint.Also applies to: 46-46
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (296)
k8s/manifests/aws/dist/awsis excluded by!**/dist/**k8s/manifests/aws/dist/aws_completeris excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/.changes/next-release/api-change-connect-59117.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/cacert.pemis excluded by!**/dist/**,!**/*.pemk8s/manifests/aws/dist/awscli/botocore/data/accessanalyzer/2019-11-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/accessanalyzer/2019-11-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/accessanalyzer/2019-11-01/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/accessanalyzer/2019-11-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/account/2021-02-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/account/2021-02-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/account/2021-02-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm-pca/2017-08-22/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm-pca/2017-08-22/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm-pca/2017-08-22/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm-pca/2017-08-22/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm-pca/2017-08-22/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm/2015-12-08/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm/2015-12-08/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm/2015-12-08/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm/2015-12-08/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/acm/2015-12-08/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/aiops/2018-05-10/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/aiops/2018-05-10/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/aiops/2018-05-10/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/aiops/2018-05-10/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amp/2020-08-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amp/2020-08-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amp/2020-08-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amp/2020-08-01/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplify/2017-07-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplify/2017-07-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplify/2017-07-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifybackend/2020-08-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifybackend/2020-08-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifybackend/2020-08-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifyuibuilder/2021-08-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifyuibuilder/2021-08-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifyuibuilder/2021-08-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/amplifyuibuilder/2021-08-11/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigateway/2015-07-09/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigateway/2015-07-09/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigateway/2015-07-09/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigateway/2015-07-09/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewaymanagementapi/2018-11-29/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewaymanagementapi/2018-11-29/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewaymanagementapi/2018-11-29/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewayv2/2018-11-29/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewayv2/2018-11-29/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apigatewayv2/2018-11-29/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfig/2019-10-09/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfig/2019-10-09/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfig/2019-10-09/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfig/2019-10-09/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfigdata/2021-11-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfigdata/2021-11-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appconfigdata/2021-11-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appfabric/2023-05-19/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appfabric/2023-05-19/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appfabric/2023-05-19/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appfabric/2023-05-19/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appflow/2020-08-23/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appflow/2020-08-23/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appflow/2020-08-23/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appintegrations/2020-07-29/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appintegrations/2020-07-29/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appintegrations/2020-07-29/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-autoscaling/2016-02-06/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-autoscaling/2016-02-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-autoscaling/2016-02-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-autoscaling/2016-02-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-insights/2018-11-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-insights/2018-11-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-insights/2018-11-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-signals/2024-04-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-signals/2024-04-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-signals/2024-04-15/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/application-signals/2024-04-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/applicationcostprofiler/2020-09-10/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/applicationcostprofiler/2020-09-10/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/applicationcostprofiler/2020-09-10/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appmesh/2019-01-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appmesh/2019-01-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appmesh/2019-01-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apprunner/2020-05-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apprunner/2020-05-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apprunner/2020-05-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appstream/2016-12-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appstream/2016-12-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appstream/2016-12-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appstream/2016-12-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appstream/2016-12-01/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appsync/2017-07-25/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appsync/2017-07-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appsync/2017-07-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/appsync/2017-07-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apptest/2022-12-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apptest/2022-12-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apptest/2022-12-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/apptest/2022-12-06/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/arc-zonal-shift/2022-10-30/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/arc-zonal-shift/2022-10-30/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/arc-zonal-shift/2022-10-30/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/arc-zonal-shift/2022-10-30/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/artifact/2018-05-10/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/artifact/2018-05-10/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/artifact/2018-05-10/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/artifact/2018-05-10/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/athena/2017-05-18/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/athena/2017-05-18/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/athena/2017-05-18/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/athena/2017-05-18/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/auditmanager/2017-07-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/auditmanager/2017-07-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/auditmanager/2017-07-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling-plans/2018-01-06/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling-plans/2018-01-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling-plans/2018-01-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling-plans/2018-01-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling/2011-01-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling/2011-01-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling/2011-01-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling/2011-01-01/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/autoscaling/2011-01-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/b2bi/2022-06-23/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/b2bi/2022-06-23/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/b2bi/2022-06-23/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/b2bi/2022-06-23/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup-gateway/2021-01-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup-gateway/2021-01-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup-gateway/2021-01-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup/2018-11-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup/2018-11-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backup/2018-11-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backupsearch/2018-05-10/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backupsearch/2018-05-10/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backupsearch/2018-05-10/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/backupsearch/2018-05-10/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/batch/2016-08-10/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/batch/2016-08-10/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/batch/2016-08-10/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/batch/2016-08-10/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-data-exports/2023-11-26/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-data-exports/2023-11-26/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-data-exports/2023-11-26/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-pricing-calculator/2024-06-19/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-pricing-calculator/2024-06-19/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-pricing-calculator/2024-06-19/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bcm-pricing-calculator/2024-06-19/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent-runtime/2023-07-26/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent-runtime/2023-07-26/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent-runtime/2023-07-26/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent-runtime/2023-07-26/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent/2023-06-05/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent/2023-06-05/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-agent/2023-06-05/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation-runtime/2024-06-13/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation-runtime/2024-06-13/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation-runtime/2024-06-13/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation/2023-07-26/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation/2023-07-26/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-data-automation/2023-07-26/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-runtime/2023-09-30/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-runtime/2023-09-30/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-runtime/2023-09-30/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock-runtime/2023-09-30/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock/2023-04-20/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock/2023-04-20/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock/2023-04-20/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/bedrock/2023-04-20/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billing/2023-09-07/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billing/2023-09-07/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billing/2023-09-07/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billing/2023-09-07/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billingconductor/2021-07-30/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billingconductor/2021-07-30/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billingconductor/2021-07-30/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/billingconductor/2021-07-30/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/braket/2019-09-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/braket/2019-09-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/braket/2019-09-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/budgets/2016-10-20/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/budgets/2016-10-20/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/budgets/2016-10-20/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/budgets/2016-10-20/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/ce/2017-10-25/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/ce/2017-10-25/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/ce/2017-10-25/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/ce/2017-10-25/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/ce/2017-10-25/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chatbot/2017-10-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chatbot/2017-10-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chatbot/2017-10-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-identity/2021-04-20/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-identity/2021-04-20/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-identity/2021-04-20/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-media-pipelines/2021-07-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-media-pipelines/2021-07-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-media-pipelines/2021-07-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-meetings/2021-07-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-meetings/2021-07-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-meetings/2021-07-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-messaging/2021-05-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-messaging/2021-05-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-messaging/2021-05-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-voice/2022-08-03/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-voice/2022-08-03/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime-sdk-voice/2022-08-03/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime/2018-05-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime/2018-05-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/chime/2018-05-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanrooms/2022-02-17/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanrooms/2022-02-17/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanrooms/2022-02-17/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanrooms/2022-02-17/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanroomsml/2023-09-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanroomsml/2023-09-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanroomsml/2023-09-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cleanroomsml/2023-09-06/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloud9/2017-09-23/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloud9/2017-09-23/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloud9/2017-09-23/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloud9/2017-09-23/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudcontrol/2021-09-30/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudcontrol/2021-09-30/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudcontrol/2021-09-30/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudcontrol/2021-09-30/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudcontrol/2021-09-30/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/clouddirectory/2017-01-11/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/clouddirectory/2017-01-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/clouddirectory/2017-01-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/clouddirectory/2017-01-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudformation/2010-05-15/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudformation/2010-05-15/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudformation/2010-05-15/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudformation/2010-05-15/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudformation/2010-05-15/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront-keyvaluestore/2022-07-26/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront-keyvaluestore/2022-07-26/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront-keyvaluestore/2022-07-26/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront/2020-05-31/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront/2020-05-31/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront/2020-05-31/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront/2020-05-31/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudfront/2020-05-31/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsm/2014-05-30/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsm/2014-05-30/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsm/2014-05-30/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsm/2014-05-30/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsmv2/2017-04-28/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsmv2/2017-04-28/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsmv2/2017-04-28/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudhsmv2/2017-04-28/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearch/2013-01-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearch/2013-01-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearch/2013-01-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearch/2013-01-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearchdomain/2013-01-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearchdomain/2013-01-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudsearchdomain/2013-01-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail-data/2021-08-11/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail-data/2021-08-11/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail-data/2021-08-11/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail/2013-11-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail/2013-11-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail/2013-11-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudtrail/2013-11-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudwatch/2010-08-01/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudwatch/2010-08-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudwatch/2010-08-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudwatch/2010-08-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/cloudwatch/2010-08-01/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeartifact/2018-09-22/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeartifact/2018-09-22/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeartifact/2018-09-22/paginators-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeartifact/2018-09-22/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codebuild/2016-10-06/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codebuild/2016-10-06/completions-1.sdk-extras.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codebuild/2016-10-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codebuild/2016-10-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codebuild/2016-10-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecatalyst/2022-09-28/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecatalyst/2022-09-28/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecatalyst/2022-09-28/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecatalyst/2022-09-28/waiters-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecommit/2015-04-13/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecommit/2015-04-13/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecommit/2015-04-13/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codecommit/2015-04-13/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeconnections/2023-12-01/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeconnections/2023-12-01/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codeconnections/2023-12-01/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codedeploy/2014-10-06/completions-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codedeploy/2014-10-06/endpoint-rule-set-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codedeploy/2014-10-06/paginators-1.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codedeploy/2014-10-06/service-2.jsonis excluded by!**/dist/**k8s/manifests/aws/dist/awscli/botocore/data/codedeploy/2014-10-06/waiters-2.jsonis excluded by!**/dist/**
📒 Files selected for processing (4)
.github/workflow/ci.yaml(1 hunks)Dockerfile(1 hunks)k8s/manifests/aws/README.md(1 hunks)k8s/manifests/aws/THIRD_PARTY_LICENSES(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
k8s/manifests/aws/README.md
8-8: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
14-14: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
15-15: Dollar signs used before commands without showing output
(MD014, commands-show-output)
24-24: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
25-25: Dollar signs used before commands without showing output
(MD014, commands-show-output)
30-30: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
31-31: Dollar signs used before commands without showing output
(MD014, commands-show-output)
39-39: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
40-40: Dollar signs used before commands without showing output
(MD014, commands-show-output)
47-47: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
48-48: Dollar signs used before commands without showing output
(MD014, commands-show-output)
49-49: Dollar signs used before commands without showing output
(MD014, commands-show-output)
50-50: Dollar signs used before commands without showing output
(MD014, commands-show-output)
🪛 YAMLlint (1.37.1)
.github/workflow/ci.yaml
[warning] 21-21: wrong indentation: expected 6 but found 4
(indentation)
[error] 34-34: trailing spaces
(trailing-spaces)
[warning] 39-39: wrong indentation: expected 6 but found 4
(indentation)
[error] 46-46: trailing spaces
(trailing-spaces)
[warning] 53-53: wrong indentation: expected 6 but found 4
(indentation)
[warning] 79-79: wrong indentation: expected 6 but found 4
(indentation)
[warning] 96-96: too many blank lines (2 > 0)
(empty-lines)
🔇 Additional comments (1)
k8s/manifests/aws/THIRD_PARTY_LICENSES (1)
1-1400: No review needed – legal text onlyThis file is pure license disclosures; nothing to review from an engineering perspective.
Comment on lines
+26
to
+38
| FROM gcr.io/distroless/base | ||
|
|
||
| # Copy the binary from the previous stage | ||
| COPY --from=base /app/main . | ||
|
|
||
| # Copy the static files from the previous stage | ||
| COPY --from=base /app/static ./static | ||
|
|
||
| # Expose the port on which the application will run | ||
| EXPOSE 8080 | ||
|
|
||
| # Command to run the application | ||
| CMD ["./main"] |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Run as a non-root user for better container hardening
gcr.io/distroless/base defaults to UID 0. Unless the binary really needs extra privileges, drop root:
FROM gcr.io/distroless/base
COPY --from=base /main /main
COPY --from=base /app/static ./static
+USER nonroot:nonroot
EXPOSE 8080
CMD ["/main"]Most distroless images ship the nonroot (65532) user, so this is a one-liner that satisfies many security scanners.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In Dockerfile lines 26 to 38, the container runs as root by default which is a
security risk. Modify the Dockerfile to switch to the non-root user by adding a
USER instruction with the nonroot user ID (65532) before the CMD line. This
change will run the application with lower privileges, improving container
security without affecting functionality.
Comment on lines
+84
to
+88
| - name: Update tag in Helm chart | ||
| run: | | ||
| sed -i 's/tag: .*/tag: "${{github.run_id}}"/' helm/go-web-app-chart/values.yaml | ||
|
|
||
| - name: Commit and push changes |
There was a problem hiding this comment.
sed replacement risks corrupting YAML – quote the tag value literally
The current command interprets the ${{github.run_id}} on the runner side, not inside the file, producing something like tag: 12345" (note unmatched quote). Use single quotes around the expression part or insert via yq:
- sed -i 's/tag: .*/tag: "${{github.run_id}}"/' helm/go-web-app-chart/values.yaml
+ sed -i "s/^ tag: .*/ tag: \"${{ github.run_id }}\"/" helm/go-web-app-chart/values.yamlOr, better:
yq e '.image.tag = strenv(GITHUB_RUN_ID)' -i helm/go-web-app-chart/values.yamlThis keeps the YAML valid even if the line has leading spaces.
🤖 Prompt for AI Agents
In .github/workflow/ci.yaml around lines 84 to 88, the sed command used to
update the tag in the Helm chart risks corrupting the YAML by improperly quoting
the tag value and interpreting the GitHub run ID on the runner side. Replace the
sed command with a yq command that sets the image.tag field using the
environment variable GITHUB_RUN_ID, ensuring the YAML remains valid and
indentation is preserved. Use the command: yq e '.image.tag =
strenv(GITHUB_RUN_ID)' -i helm/go-web-app-chart/values.yaml.
Comment on lines
+50
to
+52
| needs: build | ||
|
|
||
| steps: |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure lint passes before pushing an image
push currently depends only on build. If golangci-lint fails, the Docker image will still be published.
- push:
+ push:
runs-on: ubuntu-latest
- needs: build
+ needs: [build, code-quality]This blocks publishing on failing quality gates and avoids shipping broken code.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| needs: build | |
| steps: | |
| push: | |
| runs-on: ubuntu-latest | |
| needs: [build, code-quality] | |
| steps: |
🤖 Prompt for AI Agents
In .github/workflow/ci.yaml around lines 50 to 52, the push job depends only on
the build job, allowing the Docker image to be published even if golangci-lint
fails. Modify the push job's needs section to include both build and
golangci-lint jobs so that pushing the image only occurs if both build and lint
pass, preventing broken code from being shipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit