Implement API action ChangeMessageVisibilityBatch #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nritholtz
force-pushed
the
change_message_visibility_batch
branch
2 times, most recently
from
60820c4
to
84e68fa
Compare
nritholtz
force-pushed
the
change_message_visibility_batch
branch
from
84e68fa
to
7306482
Compare
…for message timeout' spec
|
Duplicate of #9 (merged). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #9. Since the PR was over a year old, I had to fix the specs.
Also, the Travis build for this commit was randomly failing on the 'wait for message timeout spec', even though my commit didn't have anything to do with this test. I also saw this test failing intermittently on other builds.
As a temporary fix, I increased the sleep time during the build, however, in the future we may be able to increase spec time and reliability, after merging #31. This will allow us to use a smaller sleep interval and ensure that there is ample time for the
run_timerto be ran, without sacrificing spec duration.