Strong password #288
Merged
Strong password #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set minimum entropy to 25, check password agaisnt default dictionary
Utzig26
approved these changes
May 24, 2021
|
It looks better than before. Again, following our refactoring rules, it is not the time to make it Async, but I create the #299 issue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require stronger password - Closes #285
Using strong_password gem to calculate password entropy and check it against a password dictionary. This increases password strength as users will not be able to use commonly used passwords such as "passworD12" that would be accepted by our previous validation.
Minimum entropy: 25 bits
Password Dictionary length: 500 words
Disadvantage: might not be good for user experience as they might have to try many times to enter a strong password. The value of minimum entropy can be changed, but it might affect security if set to a value smaller than 20. Check this.