-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade MSRV to 1.48 #85
Conversation
sdroege
commented
Nov 8, 2023
•
edited
Loading
edited
This is the version currently available in Debian oldstable and should be a reasonable choice. Also check in the CI that everything still compiles with that version and fixed Cargo.lock files that use older dependency versions than what cargo would select by itself. fixup
I'll try fixing the remaining CI issues tomorrow |
I'm taking a look at it now in #87 because it's some annoying xtask shenanigans and possibly dealing with windows testing in github. |
Ok, apparently powershell has aliases for |
Let's merge yours then, that's already ready and doesn't need another CI run :) |
Also thanks for fixing up the CI :) |
I wasn't sure I had permission to push to your branch. But it doesn't change anything AFAIU (squashed PRs with multiple authors are authored by the merger and co-authored by the rest).
No worries, that was on me anyway. And thanks again for bringing this issue to my attention! And I'm actually surprised you discovered it because the MSRV bump was not even released, which means you had to take a look at the repo. |