Resolve Methods flagged by no-internal in measure-tools #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most errors were resolved just by updating itwinjs-core packages to a version after the above issue was resolved. |
DanRod1999
requested review from
simnorm,
a-gagnon,
bsy-nicholasw and
a team
as code owners
aruniverse
reviewed
Jul 10, 2024
change/@itwin-measure-tools-react-a682d053-c4ed-4aec-8a4c-4e33bbe76d16.json
Outdated
Show resolved
Hide resolved
aruniverse
reviewed
Jul 10, 2024
change/@itwin-measure-tools-react-a682d053-c4ed-4aec-8a4c-4e33bbe76d16.json
Outdated
Show resolved
Hide resolved
aruniverse
reviewed
Jul 18, 2024
change/@itwin-measure-tools-react-a682d053-c4ed-4aec-8a4c-4e33bbe76d16.json
Outdated
Show resolved
Hide resolved
aruniverse
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #989
utilized work from this issue and related PRs
https://github.com/iTwin/itwinjs-backlog/issues/782
fillEventFromLastDataButton and fillEventFromLastDataButton promoted in: iTwin/itwinjs-core#5720
doSnapRequest api created by: iTwin/itwinjs-core#5720
toolSettingsState promoted in: iTwin/itwinjs-core#5672
createQueryReader promoted from beta in: iTwin/itwinjs-core#5788