Measure-tools-react: drawingTypeCache refactor #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxime-Brassard
requested review from
simnorm,
a-gagnon,
bsy-nicholasw and
a team
as code owners
Maxime-Brassard
changed the title
a-gagnon
reviewed
Jul 10, 2024
a-gagnon
reviewed
Jul 10, 2024
a-gagnon
reviewed
Jul 15, 2024
a-gagnon
reviewed
Jul 15, 2024
a-gagnon
reviewed
Jul 15, 2024
a-gagnon
reviewed
Jul 15, 2024
a-gagnon
reviewed
Jul 25, 2024
bsy-nicholasw
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the drawingTypeCache so that it is easier to use and keeps the drawing types so that it does not run again when it goes back to a previously checked sheet.
Also made it a singleton so that it persists between tools.
Per the comment made on this PR: https://dev.azure.com/bentleycs/Civil-iTwin/_git/Civil-iTwin/pullrequest/441863