Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/missing peerdeps #714

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix/missing peerdeps #714

wants to merge 3 commits into from

Conversation

a-gagnon
Copy link
Contributor

@a-gagnon a-gagnon commented Dec 15, 2023

Add missing peerDependencies that are required at runtime by the map-layers package.
Besides type imports, anything that is used by the package should be a direct dependency, or be in both devDependency and peerDependency.

  • Move some devDependencies to direct dependencies

Found the problem when adding the @itwin/map-layers package to my test-app. I didn't get a warning for missing peerDependency, but it complained about missing @itwin/map-layers-formats at build time.

…encies but are required by the map-layers package at runtime.
@a-gagnon a-gagnon enabled auto-merge (squash) December 15, 2023 15:50
@aruniverse aruniverse disabled auto-merge July 2, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants