Skip to content

Add volume measurement tool #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add volume measurement tool #1024

wants to merge 3 commits into from

Conversation

saaaaaally
Copy link
Contributor

Add Volume measurement tool. Tool is a special case since it is only applicable to meshes so it is off by default and can be enabled with the showVolumeTool flag.

volumeTool

Copy link
Contributor

@a-gagnon a-gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I review any further, let me start by saying this:
-I don't think this code should go in viewer-components-react.
-Unlike the name suggests, this is not some generic volume calculation tool. It uses the viewport and the current level of detail to compute an approximate volume. This is relevant for stockpiles, but would fail badly for anything that is hollow.

@bsy-nicholasw
Copy link
Contributor

@saaaaaally I agree with Alex. Civil has a lot of custom tools that we do not add to this repo, it's OK and in the spirit of the original intentions of the library for the app to have it's own measurement types and leave super generic types to the base library.

We may need to know if multiple apps are requesting this type of tool, which in that case yes it makes sense to have it here to lessen dependency burdens, but it probably should be renamed to not convey that it's a generic volume measurement -or- something that gets volumes from the real elements instead of the LOD display.

@saaaaaally saaaaaally closed this Jan 7, 2025
@aruniverse aruniverse deleted the saally/AddVolumeTool branch January 7, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants