-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed position for formation flight / inav radar #9883
Conversation
@error414 Nice idea !
Having the possibility to add info about multiple peers would be useful if the pilot desires.. What type of layout method did you have in mind for this peer information ? |
@error414 Can it be made to work independently of the crosshair? So it doesn't require a crosshair to display the formation flight data as it does currently with all the radar HUD functions. |
@Jetrell In second line are two informations, distance to peer, and altitude diff to peer. It can be set by osd_hud_radar_alt_difference_display_time and osd_hud_radar_alt_difference_display_time see https://github.com/iNavFlight/inav/blob/master/docs/Settings.md#osd_hud_radar_distance_display_time Maybe I would like to see both information at the same time. I don't know now :). I'm open to any ideas. @rts18 |
I figure most people will only fly as a pair. Presently |
so, do you suggest to three lines for each peer? [heading][peer ID][LQ][direction to peer] This PR does not use param "osd_hud_radar_disp " because it's not necesesary, it show only one peer, the closest one. How much peers can be stored in memory is defined here https://github.com/iNavFlight/inav/blob/master/src/main/navigation/navigation.h#L456 , there is 5, but I would say it includes your peer as well. For example, if you fly with your friend, there will be stored your peer (everytime 0m distance) and your friend. So 5 means you + next four peers. New peer is alsways saved to next index, So you are always 0, then your friend is 1, That index correspond to letter on screen. 0 = A, 1 = B ... So if I would allow to show more peers, how to order them? Imagine, you turn on plane, you will be in index 0, then some ghost peer apper and it's saved in index 1, then your friend turn up plane, and he will be in index 2. In this case you expect only one peer and you set that only peer B will be visble, because there is ghost peer, you will never see your friend because he is C. So you would have to put to OSD all four OSD elements, for each peer ,to be sure your friend will be on screen. How it could look with 3 lines, no peer / the clossest peer: |
thank you, this was on my attempt to do list for a while. a a static positioned indicator is much preferred for me. thanks again. |
To contribute to the discussion on layout: When I wrote support for Ardupilot, I also chose not to implement the "HUD" style display. I have a single, simple, static element which contains all the peers in the following way:
Every two seconds, the element checks for the "next" peer with fresh data. If that's the current peer, nothing happens and it stays on the same peer. So for flying as a pair, you'd only see your friend. When a third shows up, the element shows friend 1 for two seconds, then friend 2 for two seconds, then rotates back around. I've found this to be more than sufficient to fly up to four people in the air at a time, since once you're close enough to need data more frequently than that you're generally already in range. You can find my other PR ArduPilot/ardupilot#25684 where I've included a screenshot of what the element looks like in flight. |
@error414
I thought it may be beneficial.. The element isn't moving all over the place like the HUD does. So an extra line of 4 characters wouldn't be too bulky. |
59a34a3
to
0c75483
Compare
OBS can record from X-Plane. Well, X-Plane 11 at least. I've done it a few times. Off the top of my head. I captured the whole screen. |
@error414 SneakyFPV font packages include the radar icon you prefer for use with Walksnail : https://drive.google.com/drive/folders/1IMGjPGR9hSTKJmKyhVOn6UYDWRlsQSU0 > OLDER > INAV6 > BATMAN
Many of us have also become familiar with @MrD-RC cardinal radar layout. As you describe in this image. The use of three different icon types is beneficial for fast deciphering of the data at a glance. Rather than having two of the same hard coded 2D icons used to describe two separate data fields. Peer heading is an extremely important data point when peers are not in the immediate vicinity. Without it, you can not know if your paths will intersect. You may know their azimuth, but not their heading comparing to your own. May we request the layout stays the same. While allowing users to select or customize their own glyphs, or icons as you refer to them. |
@rts18 |
@error414 I think you misunderstand my meaning. I have no issue with your fixed position radar concept. I was merely stating, can you keep the layout of the radar icon information the same as it is on the HUD radar. Based on the image in your post #9883 (comment) However from your last commit, it seemed you added cycling peers to one fixed icon, as mustard tiger suggested? I'm fine with either method. |
it's lattest test https://www.youtube.com/watch?v=sNFlpUCxnGM center-bottom is new one, others are old ones without any changes. Icon set in HITL can look diferent, icons ID should be same as original ones. Peer E is quite hysterical, because there are three peers on the same place. ID of peers from inav radar VS OSD are moved, +1. See screenshot. So OSD peer E is peers D E F from inav radar. It's necessary to test on the field because on the bench behavior could be quite different. I did not change anything about communnication INAV <-> INav radar so I expect it works well, just some issues on bench. Maybe I will apply same restriction as there are for old inav radar elements, I would solve the issue. And I'm thinking I will add next settings to cli, switch between inav and ardu style. |
Would be also cool to switch off/on icons what you want to have and what you do not need. Only in CLI on/off. So that everybody can select the chars/Icons... what is needed. For me for example I don´t need the Information about A/B/C because mostly we are only 2 people so all will be smaller. |
I decided to keep is as it's on video . https://www.youtube.com/watch?v=sNFlpUCxnGM
If I would use same layout for fixed element as it's for floating element, then there would be two changes base on time in elemet.
I would say it's too much. If anybody is familiar with floating layout then will not be any problem to "decode" fixed layout. |
You should change the arrow on the fixed version to match the floating version. It needs to be as consistent as possible. |
@error414 Looking fine. |
Ahh, I forgot to mention it. Icons of fixed element will be exactly same as it's for floating version. I use defalt icon set in HITL plugin for xplane 11. Sometimes icons in xplane looks diferent. You can see on my screenshots that even floating version has weird 2d icon for heading. |
With X-Plane. You can put updated font in the plugin directory. They're a little bit buried. But look through the plugin and you'll find the analogue and digital fonts. It's useful when testing new elements. |
0c75483
to
2ef6ecb
Compare
tested on two planes on the field and it works like a charm |
Thank goodness a coding wizard finally put a leash on that rogue OSD info. It was zipping around like a hyperactive squirrel on espresso |
anyway to get a 7.1.0 version of this? i'm having trouble getting it to build cherry picking this change in. thanks |
not sure if it works properly, https://github.com/error414/inav/tree/release_7.1.1 |
bb53a28
to
ceba26a
Compare
spoof tested with inav7.1.1 cherrypick, works as desired. i'd add it to cms menu though #if defined(USE_GPS) |
flight tested today, worked great |
ceba26a
to
8d0b865
Compare
can this get merged? |
@error414 can you fix the conflict in osd.h? |
8d0b865
to
f4ce36f
Compare
pullrequest is rebased to master. Configurator iNavFlight/inav-configurator#2029 BTW: just I noticed that OSD element https://github.com/iNavFlight/inav/blob/master/src/main/io/osd.h#L288 is not in configurator. ID: 152 (OSD_BLACKBOX) is missing, there is only 151 (ADSB_INFO) and then 153 (FORMATION_FLIGHT) |
The blackbox stuff is in iNavFlight/inav-configurator#1941 |
Looks like it was bumped to 11 on master already, going +1
Hi, I don't like "flying" info on the screen about friends (inav radar), so I created proof of concept of fixed position info about the closest peer.
It's new OSD element, I would like open discustion if it's better to create new OSD element (so keep it as I done it) or provide info about the closest peer into inav programming framework and then use custom OSD elements drivven by programming framework.
So far it works nicely on the bench.
So main question, provide info about the closest peer from inav radar to programming framework, or keep it as it is
CONFIGURATOR: iNavFlight/inav-configurator#2029