Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Readme.md #1857 #1859

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Update the Readme.md #1857 #1859

merged 8 commits into from
Oct 28, 2023

Conversation

CrypticRevenger
Copy link
Contributor

@CrypticRevenger CrypticRevenger commented Oct 28, 2023 •
edited by MrD-RC
Loading

#1857
updated in correcting the grammar, verbs, articles , spellings, preposition ,pronoun.

Fixes #1857

MrD-RC
MrD-RC requested changes Oct 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated

## Font Customisation

INAV provides the font images so that custom fonts can be created for your personal preference. This is the case for both analogue and digital fonts. The resources can be found in the [osd](/resources/osd) folder. Within the **analogue** and **digital** subfolders, you will find information on compiling your own fonts. There is also an [INAV Character Map](/resources/osd/INAV%20Character%20Map.md) document. This contains previews of all the character images in the fonts, and the appropriate variable names within the firmware and Configurator. There are tools for compiling the [analogue](https://github.com/fiam/max7456tool) and [digital](https://github.com/MrD-RC/hdosd-font-tool) fonts. New font submissions via pull requests are welcome.
Copy link
Collaborator

@MrD-RC MrD-RC Oct 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is fine as is, with the word own.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also still needs resolution.

MrD-RC
MrD-RC reviewed Oct 28, 2023
View reviewed changes
README.md Show resolved Hide resolved
@MrD-RC MrD-RC added this to the 7.0 milestone Oct 28, 2023
@CrypticRevenger
Copy link
Contributor Author

@MrD-RC please review the pr.

MrD-RC
MrD-RC requested changes Oct 28, 2023
View reviewed changes
README.md Outdated

#### Notes

On some Linux distros, you may be missing `libatomic`, a `NW.JS` (specially `libnode.so`) dependency. If so, please install `libatomic` using your distro's package manager, e.g:
On some Linux distros, you may be missing `libatomic`, an `NW.JS` (especially `libnode.so`) dependency. If so, please install `libatomic` using your distro's package manager, e.g:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as:

missing libatomic and/or NW.JS (especially libnode.so) dependencies.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 28, 2023

Spotted another change.

MrD-RC
MrD-RC reviewed Oct 28, 2023
View reviewed changes
README.md Outdated
@@ -78,7 +78,7 @@ sudo mv inav-configurator.desktop /usr/share/applications/

#### Notes

On some Linux distros, you may be missing `libatomic`, an `NW.JS` (especially `libnode.so`) dependency. If so, please install `libatomic` using your distro's package manager, e.g:
On some Linux distros, you may be missing `libatomic`or `NW.JS` (especially `libnode.so`) dependency. If so, please install `libatomic` using your distro's package manager, e.g:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is should be and/or because it could be both, one, or none. Also, dependency should be dependencies because it should be plural.

@CrypticRevenger
Copy link
Contributor Author

CrypticRevenger commented Oct 28, 2023 •
edited
Loading

@MrD-RC I think there should be "Z" in "Font customisation" .
and the previous issue resolved

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 28, 2023

@MrD-RC I think there should be "Z" in "Font customisation" . and the previous issue resolved

Definitely no ‘z’ in Customisation. Z are in the American spelling, not English spelling.

@CrypticRevenger
Copy link
Contributor Author

@MrD-RC sir, can you please merge this issue,
That will be very helpful for me.
Thank you.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Oct 28, 2023

Thanks for doing this.

Just one thing to note is that some of the words may look incorrect. For example dialout. But they are technically correct because they are referencing something in code or an OS. A lot of the time, they will likely be in a single or triple single-quote block. But they could be anywhere. To be honest, I was unsure about dialup. Until I saw it in the code to be entered in to Terminal on the next line.

@MrD-RC MrD-RC merged commit 6f77b8b into iNavFlight:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrD-RC MrD-RC MrD-RC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Update the Readme.md
2 participants
@CrypticRevenger @MrD-RC