-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BFHDCOMPAT #1747
Add BFHDCOMPAT #1747
Conversation
I am currently looking into an issue in the configurator where the preview size is not updated correctly. |
Still plan on adding guides for native elements
Still need to cross reference with the actual googles osd
I have made some changes to the reference bars, to better match what I get on my goggles (FPV V2). The vertical red bars are basically not needed, you can go up to the very corners of the screen without a problem. I moved them to be very close to the actual edges. The bottom area doesn't need to cover the whole width of the screen, just the rightmost corner. I have adjusted the bottom horizontal line to start at proper location, however I think that adding a small vertical line there to fully close the outline would be a good idea. And here's the code changes I have made (just changed the positioning numbers). All of them on the osd.css file. Lines 438 to 452:
Lines 561 to 603:
|
@rmaia3d The red border is for 4:3 aspect ratio, if you don't want you text to extend beyond the video. I increased the size of the storage box a bit and changed the bottom line to be a box. I also made it bigger, to also cover the alerts, like the low power mode indicator. |
Oh!! I didn't think about the 4:3 mode (I use only 16:9), but yeah, makes total sense!! 👍 Also, increasing the size of the bottom box to also cover the DJI alert ribbon was a good idea. Nice! |
This adds bfcompat support to the configurator