Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BFHDCOMPAT #1747

Merged
merged 13 commits into from
Mar 29, 2023
Merged

Add BFHDCOMPAT #1747

merged 13 commits into from
Mar 29, 2023

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Mar 29, 2023

This adds bfcompat support to the configurator

@mmosca mmosca added this to the 6.1 milestone Mar 29, 2023
@mmosca
Copy link
Collaborator Author

mmosca commented Mar 29, 2023

I am currently looking into an issue in the configurator where the preview size is not updated correctly.

Still plan on adding guides for native elements
Still need to cross reference with the actual googles osd
@rmaia3d
Copy link

rmaia3d commented Mar 29, 2023

I have made some changes to the reference bars, to better match what I get on my goggles (FPV V2).

The vertical red bars are basically not needed, you can go up to the very corners of the screen without a problem. I moved them to be very close to the actual edges.

The bottom area doesn't need to cover the whole width of the screen, just the rightmost corner. I have adjusted the bottom horizontal line to start at proper location, however I think that adding a small vertical line there to fully close the outline would be a good idea.

Resulting preview image:
Screen Shot 2023-03-29 at 11 57 12

And here's the code changes I have made (just changed the positioning numbers). All of them on the osd.css file.

Lines 438 to 452:

.tab-osd .hd_bfhdcompat_43_left {
	border-left: 2px solid red;
	position: absolute;
	/*left: 77.5px; // Calculated correct position */
    left: 2px;
	height: calc(100% - 27px);
}

.tab-osd .hd_bfhdcompat_43_right {
	border-right: 2px solid red;
	position: absolute;
	/* right: 77.5px; // Calculated correct position */
    right: 4px;
	height: calc(100% - 27px);
}

Lines 561 to 603:

.tab-osd .hd_bfhdcompat_bottom {
    border-bottom: 2px solid purple;
    position: absolute;
    bottom: 22px;
    left: 450px;
    right: 0px;
}

.tab-osd .hd_bfhdcompat_storagebox_t {
    border-top: 2px solid purple;
    position: absolute;
    top: 125px;
    height: 1px;
    right: 10px;
    width: 71px;
}

.tab-osd .hd_bfhdcompat_storagebox_b {
    border-bottom: 2px solid purple;
    position: absolute;
    top: 158px;
    height: 1px;
    right: 10px;
    width: 71px;
}

.tab-osd .hd_bfhdcompat_storagebox_l {
    border-left: 2px solid purple;
    position: absolute;
    top: 125px;
    height: 35px;
    right: 79px;
    width: 1px;
}

.tab-osd .hd_bfhdcompat_storagebox_r {
    border-right: 2px solid purple;
    position: absolute;
    top: 125px;
    height: 35px;
    right: 10px;
    width: 1px;
}

@mmosca
Copy link
Collaborator Author

mmosca commented Mar 29, 2023

@rmaia3d The red border is for 4:3 aspect ratio, if you don't want you text to extend beyond the video.

I increased the size of the storage box a bit and changed the bottom line to be a box.

I also made it bigger, to also cover the alerts, like the low power mode indicator.

@mmosca mmosca marked this pull request as ready for review March 29, 2023 16:38
@rmaia3d
Copy link

rmaia3d commented Mar 29, 2023

Oh!! I didn't think about the 4:3 mode (I use only 16:9), but yeah, makes total sense!! 👍

Also, increasing the size of the bottom box to also cover the DJI alert ribbon was a good idea. Nice!

@mmosca mmosca merged commit 0d5813e into release_6.1.0 Mar 29, 2023
@mmosca mmosca deleted the bfhd branch March 29, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants