2544 terraform s3 policy

[m-s-austin]

This code adds a new provider to terraform that allows you to add a Policy to an s3 bucket like this:

resource "aws_s3_bucket_policy" "test_policy" {
name = "Bucket Test Policy"
bucket = "${aws_s3_bucket.b.id}"
policy = <<EOF
{
"Id": "Policy1431447664360",
"Version": "2012-10-17",
"Statement": [
{
"Sid": "Stmt1431447659873",
"Action": [
"s3:GetObject"
],
"Effect": "Allow",
"Resource": "arn:aws:s3:::my_tf_test_bucket/",
"Principal": ""
}
]
}
EOF
}

[chimmelb]

+1
Admittedly I don't know Go. The code looks clean enough.

[tehnorm]

Did we figure out the unit testing process? Would love to see working unit tests with this before we merge it down.

[m-s-austin]

@tehnorm They have "acceptance tests" but not "unit tests" the acceptance tests still run, I can work on figuring out how to write more. They appear to be more of an integration type test than a unit test, in that they actually create / destroy live resources on the services.

It's going to take at least a day or two of research to understand how to write my own. However, I might be able to get some feedback from hashicorp. that might help.

[Carrington]

So I also do not know Go, but would it be possible to give these variables some more descriptive names? What is 'd', for instance?

[m-s-austin]

It's basically their standard:
https://godoc.org/github.com/hashicorp/terraform/helper/schema#pkg-index

d *ResourceData technically if I was going strictly by their practices I probably should have stuck with m for meta.

I agree it's not very descriptive.

[m-s-austin]

I will probably be closing this in favor of
hashicorp#1992

I have been testing it and it seems to have all the same functionality as well as already having tests.

[m-s-austin]

1992 has already been merged into master on hashicorp.