Refactor: Randomize the urls when we run Lighthouse #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this were were creating a new list of urls to audit and appending a random parameter to each url. This is necessary to ensure that we are not hitting a CDN cache when we are trying to audit the urls. However, when we send the metrics to DataDog, we send the modified url. This causes the metrics to be unique and harder to aggregate or create trends on. We can't drop the group by 'url' in DataDog because we might be sending multiple urls for the same page type which would cause the metrics to be aggregated incorrectly. Instead, let's only modify the urls when we are starting the lighthouse runner which will allow us to send the original url to DataDog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this were were creating a new list of urls to audit and appending a random parameter to each url. This is necessary to ensure that we are not hitting a CDN cache when we are trying to audit the urls. However, when we send the metrics to DataDog, we send the modified url. This causes the metrics to be unique and harder to aggregate or create trends on.
We can't drop the group by 'url' in DataDog because we might be sending multiple urls for the same page type which would cause the metrics to be aggregated incorrectly.
Instead, let's only modify the urls when we are starting the lighthouse runner which will allow us to send the original url to DataDog.
qa_req 0 I already validated this works by running
pnpm run build && pnpm run startand confirmed the urls in DataDog no longer had therandparameter.Connects: https://github.com/iFixit/ifixit/issues/51901