Add build-image.yml deployment workflow for the docker image #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is almost the same deployment workflow we use in data-pipelines repository to build, tag and push the image to ECR: https://github.com/iFixit/data-pipelines/blob/main/.github/workflows/build-image.yml Saved the `role-to-assume` value in repository variables in the repo.
|
deploy_block 🚛 on #17 going out first |
ardelato
reviewed
Dec 5, 2023
ardelato
reviewed
Dec 5, 2023
batbattur
commented
Dec 5, 2023
batbattur
commented
Dec 5, 2023
We don't want to trigger the deployment workflow for security reasons.
ardelato
previously approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is almost the same deployment workflow we use in
data-pipelinesrepository to build,tag, and push the image to ECR:
https://github.com/iFixit/data-pipelines/blob/main/.github/workflows/build-image.yml
Saved the
role-to-assumevalue in the secrets.QA notes
We probably have to merge this to test it (not really sure how to test without merging it).
qa_req 0
closes #15