Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Conversation

@davidrans
Copy link
Contributor

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 5:04PM (UTC)
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 5:04PM (UTC)

@davidrans
Copy link
Contributor Author

davidrans commented Mar 9, 2023

Looks like this type change exposed a potential bug in our code: getsentry/sentry-javascript#7361

Checks that the original exception is an `Error` before trying to access it's `message` property. In getsentry/sentry-javascript#7361 the type of `originalException` changed to unknown, because in reality anything can be thrown in JS.
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 353.42 KB (🟡 +1.21 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 8.03 KB (🟢 -2 B) 361.46 KB
/Parts 50 KB (🟡 +1 B) 403.42 KB
/Parts/[...deviceHandleItemType] 50.02 KB (🟡 +1 B) 403.44 KB
/Shop/[handle] 50 KB (🟡 +1 B) 403.43 KB
/Tools 50 KB (🟡 +1 B) 403.42 KB
/Tools/[handle] 50 KB (🟡 +1 B) 403.43 KB
/Vulcan/[wikiname] 9.62 KB (🟢 -2 B) 363.04 KB
/_error 663 B (🟢 -7 B) 354.07 KB
/products/[handle] 81.47 KB (-1 B) 434.89 KB
/store 41.93 KB (-1 B) 395.35 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Contributor

@masonmcelvain masonmcelvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✌🏻 QA ✌🏻 I ran this locally and threw an error in product/server.ts, and it still got reported to sentry

@masonmcelvain masonmcelvain merged commit 8618c37 into main Mar 10, 2023
@masonmcelvain masonmcelvain deleted the sentry--upgrade-7-42 branch March 10, 2023 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants