Allow Job body to be "anything" (Vec<u8> instead of String) #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the amazing work on this Beanstalkd client.
I was about to use it for a project but I needed Jobs to be able to handle raw bytes payloads (not just utf-8 encoded strings).
Long story short, we send gzipped payload (that might not be all utf-8 chars), which lead to Utf8Error in the automatic conversion.
We can argue this choice, but we could also give the choice to the library users, with this pull request :)
So, this is a slight modification of the API:
I'm pretty sure you don't want to merge this as-is, so feel free to ask for modifications.