Re-allow unknown keys, when a defaultValue is provided #1867

i18next · Jun 29, 2023 · 06d997d · 06d997d
1 parent bf17cf1
commit 06d997d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
+## 23.2.6
+
+- Re-allow unknown keys, when a defaultValue is provided [1867](https://github.com/i18next/i18next/issues/1867)
+
 ## 23.2.5
 
-- Clean language code before passing to formatters [1985](https://github.com/i18next/i18next/pull/1988)
+- Clean language code before passing to formatters [1988](https://github.com/i18next/i18next/pull/1988)
 
 ## 23.2.4
 

diff --git a/index.d.ts b/index.d.ts
@@ -915,6 +915,8 @@ export interface TFunction<Ns extends Namespace = _DefaultNamespace, KPrefix = u
     ...args:
       | [key: Key | Key[], options?: TOpt & InterpolationMap<Ret>]
       | [key: Key | Key[], defaultValue: string, options?: TOpt & InterpolationMap<Ret>]
+      | [key: string | string[], options: TOpt & InterpolationMap<Ret> & { defaultValue: string }]
+      | [key: string | string[], defaultValue: string, options?: TOpt & InterpolationMap<Ret>]
   ): TFunctionReturnOptionalDetails<Ret, TOpt>;
 }
 

diff --git a/test/typescript/custom-types/t.test.ts b/test/typescript/custom-types/t.test.ts
@@ -73,6 +73,9 @@ function expectErrorWhenKeyNotInNamespace(t: TFunction<'alternate'>) {
 
   t('foobar.barfoo', 'some default value');
   t('foobar.barfoo', { defaultValue: 'some default value' });
+
+  t('new.key', { defaultValue: 'some default value' });
+  t('new.key', 'some default value');
 }
 
 function i18nextTUsage() {