perf: use object deconstruction, optional chaining and hot path optimisations #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
commented
May 12, 2024
| } | ||
|
|
||
| return found; | ||
| return undefined; |
There was a problem hiding this comment.
This is not strictly needed but would cause errors in ESlint unless I change the rules.
|
landed in v8.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of the changes in #286 to use object deconstruction, optional chaining and optimises some code hot paths with early returns and simplified nesting.
This should be functional equivalent to the current code but produce even smaller code bundles and be ever so slightly faster.
Checklist
npm run testChecklist (for documentation change)