Repository navigation
fix(B06): guard decoded PNG dimensions across all egui previews - #29
Merged
Merged
Conversation
i-shutov
marked this pull request as ready for review
October 31, 2026 08:54
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline and isolation
Independent B lane B06, base main
8764a732b9a846a6ba1f111c9b656781195a6412. At start, #25/#26/#27/#28 were open. PR #24, themes #16 and B03/B04 were already merged. B05 #25 caps compressed PNG and Poppler timeouts; this PR independently caps decoded image dimensions and does not touch B05pdf_navigation.rs.Implementation
src/preview_image.rs: PNG-only validation of signature/IHDR, 64 MiB compressed budget, 8192 px max edge, 8,388,608 px max image; strict image-rs width/height limits and best-effort 96 MiB decoder allocation hint.plans/,insights/, andQA_PREVIEW_IMAGE_LIMITS.mdwith physical platform smoke matrix.Evidence / no false PASS
max_allocis best-effort. Large figures can be rejected; exact PDF export remains authoritative.Follow-up
Inspect exact SHA GitHub Actions; fix only this branch if red. After hosted CI evidence, ask QA to execute B06 physical smoke with screenshots/hash ledger. Independently mergeable with #25 (disjoint file paths).
CI checkpoint at exact B06 SHA
f76eef6012b7889e6139f199c5eb0e7be3d9d6ce(2026-10-31)Observed D QA matrix #41184179011: Linux fmt/workspace tests/Clippy completed/success, real XeLaTeX CLI jobs on Linux, hosted macOS 15 and Windows Server 2022 completed/success; native Rust jobs on hosted Windows/macOS still running/queued at this checkpoint. Figure-font gate #41184178997 completed/success. Standard CI #41184178998: XeLaTeX Linux fixture job completed/success, Windows/macOS Rust jobs in progress. No overall B06 CI PASS is asserted while pending jobs remain. Physical Win10 and physical Mac ARM screenshots are NOT_RUN.