Merge preact v10 upstream

.editorconfig

@@ -10,7 +10,6 @@ insert_final_newline = true
 [{*.json,.*rc,*.yml}]
 indent_style = space
 indent_size = 2
-insert_final_newline = false
 
 [*.md]
 trim_trailing_whitespace = false

.github/workflows/benchmarks.yml

@@ -2,51 +2,33 @@ name: Benchmarks
 
 on:
   workflow_dispatch:
-  pull_request:
-    branches:
-      - '**'
-    paths:
-      - '**/src/**.js'
-  push:
-    branches:
-      - main
-      - v11
-    paths:
-      - '**/src/**.js'
+  workflow_call:
 
 jobs:
-  build_test:
-    name: Build & Test
-    uses: ./.github/workflows/ci.yml
-
   prepare:
     name: Prepare environment
     runs-on: ubuntu-latest
-    needs: build_test
     timeout-minutes: 5
     steps:
       - name: Download locally built preact package
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: npm-package
       - run: mv preact.tgz preact-local.tgz
-      - name: Upload locally built preact package
-        uses: actions/upload-artifact@v3
-        with:
-          name: bench-environment
-          path: preact-local.tgz
       - name: Download base package
         uses: andrewiggins/download-base-artifact@v3
         with:
           artifact: npm-package
           workflow: ci.yml
           required: false
       - run: mv preact.tgz preact-main.tgz
-      - name: Upload base preact package
-        uses: actions/upload-artifact@v3
+      - name: Upload locally build & base preact package
+        uses: actions/upload-artifact@v4
         with:
           name: bench-environment
-          path: preact-main.tgz
+          path: |
+            preact-local.tgz
+            preact-main.tgz
 
   bench_todo:
     name: Bench todo

.github/workflows/build-test.yml

@@ -0,0 +1,58 @@
+name: Build & Test
+
+on:
+  workflow_dispatch:
+  workflow_call:
+    inputs:
+      ref:
+        description: 'Branch or tag ref to check out'
+        type: string
+        required: false
+        default: ''
+      artifact_name:
+        description: 'Name of the artifact to upload'
+        type: string
+        required: false
+        default: 'npm-package'
+
+jobs:
+  build_test:
+    name: Build & Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ inputs.ref || '' }}
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: 'package.json'
+          cache: 'npm'
+          cache-dependency-path: '**/package-lock.json'
+      - run: npm ci
+      - name: test
+        env:
+          CI: true
+          COVERAGE: true
+          FLAKEY: false
+        # Not using `npm test` since it rebuilds source which npm ci has already done
+        run: npm run lint
+      - name: Coveralls GitHub Action
+        if: github.repository == 'preactjs/preact'
+        uses: coverallsapp/github-action@v2.3.0
+        timeout-minutes: 2
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          fail-on-error: false
+      - name: Package
+        # Use --ignore-scripts here to avoid re-building again before pack
+        run: |
+          npm pack --ignore-scripts
+          mv preact-*.tgz preact.tgz
+      - name: Upload npm package
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ inputs.artifact_name || 'npm-package' }}
+          path: preact.tgz
+      - name: Publish with pkg.pr.new
+        run: |
+          npx pkg-pr-new publish --json

.github/workflows/ci.yml

@@ -2,65 +2,45 @@ name: CI
 
 on:
   workflow_dispatch:
-  workflow_call:
-    inputs:
-      ref:
-        description: 'Branch or tag ref to check out'
-        type: string
-        required: false
-        default: ''
-      artifact_name:
-        description: 'Name of the artifact to upload'
-        type: string
-        required: false
-        default: 'npm-package'
   pull_request:
     branches:
       - '**'
   push:
     branches:
       - main
-      - restructure
-      - lynx/v10.24.x
+      - v10.x
 
 jobs:
-  build_test:
-    name: Build & Test
+  filter_jobs:
+    name: Filter jobs
     runs-on: ubuntu-latest
+    outputs:
+      jsChanged: ${{ steps.filter.outputs.jsChanged }}
     steps:
       - uses: actions/checkout@v4
+      - uses: dorny/paths-filter@v3
+        id: filter
         with:
-          ref: ${{ inputs.ref || '' }}
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: 'package.json'
-          cache: 'npm'
-          cache-dependency-path: '**/package-lock.json'
-      - run: npm ci
-      - name: test
-        env:
-          CI: true
-          COVERAGE: true
-          FLAKEY: false
-        # Not using `npm test` since it rebuilds source which npm ci has already done
-        run: |
-          npm run lint
-      - name: Coveralls GitHub Action
-        if: github.repository == 'preactjs/preact'
-        uses: coverallsapp/github-action@v2.3.0
-        timeout-minutes: 2
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Package
-        # Use --ignore-scripts here to avoid re-building again before pack
-        run: |
-          npm pack --ignore-scripts
-          mv preact-*.tgz preact.tgz
-      - name: Upload npm package
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ inputs.artifact_name || 'npm-package' }}
-          path: preact.tgz
-      - name: Publish with pkg.pr.new
-        run: |
-          npx pkg-pr-new publish --json
+          # Should be kept in sync with the filter in the PR Reporter workflow
+          predicate-quantifier: 'every'
+          filters: |
+            jsChanged:
+              - '**/src/**/*.js'
+              - '!devtools/src/devtools.js'
+
+  compressed_size:
+    name: Compressed Size
+    needs: filter_jobs
+    if: ${{ needs.filter_jobs.outputs.jsChanged == 'true' }}
+    uses: ./.github/workflows/size.yml
+
+  build_test:
+    name: Build & Test
+    needs: filter_jobs
+    uses: ./.github/workflows/build-test.yml
+
+  benchmarks:
+    name: Benchmarks
+    needs: build_test
+    if: ${{ needs.filter_jobs.outputs.jsChanged == 'true' && github.repository == 'preactjs/preact' }}
+    uses: ./.github/workflows/benchmarks.yml

.github/workflows/pr-reporter.yml

@@ -4,19 +4,45 @@ on:
   # The pull_request event can't write comments for PRs from forks so using this
   # workflow_run workflow as a workaround
   workflow_run:
-    workflows: ['Benchmarks']
-    branches: ['**']
+    workflows: ['CI']
     types:
       - completed
       - requested
 
 jobs:
+  filter_jobs:
+    name: Filter jobs
+    runs-on: ubuntu-latest
+    if: |
+      github.event.workflow_run.event == 'pull_request'
+    outputs:
+      jsChanged: ${{ steps.filter.outputs.jsChanged }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dorny/paths-filter@v3
+        id: filter
+        with:
+          # As this Workflow is triggered by a `workflow_run` event, the filter action
+          # can't automatically assume we're working with PR data. As such, we need to
+          # wire it up manually with a base (merge target) and ref (source branch).
+          base: ${{ github.event.workflow_run.pull_requests[0].base.sha }}
+          ref: ${{ github.event.workflow_run.pull_requests[0].head.sha }}
+          # Should be kept in sync with the filter in the CI workflow
+          predicate-quantifier: 'every'
+          filters: |
+            jsChanged:
+              - '**/src/**/*.js'
+              - '!devtools/src/devtools.js'
+
   report_running:
     name: Report benchmarks are in-progress
+    needs: filter_jobs
     runs-on: ubuntu-latest
     # Only add the "benchmarks are running" text when a workflow_run is
     # requested (a.k.a starting)
-    if: ${{ github.event.action == 'requested' }}
+    if: |
+      needs.filter_jobs.outputs.jsChanged == 'true' &&
+      github.event.action == 'requested'
     steps:
       - name: Report Tachometer Running
         uses: andrewiggins/tachometer-reporter-action@v2
@@ -27,25 +53,30 @@ jobs:
 
   report_results:
     name: Report benchmark results
+    needs: filter_jobs
     runs-on: ubuntu-latest
     # Only run this job if the event action was "completed" and the triggering
     # workflow_run was successful
-    if: ${{ github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success' }}
+    if: |
+      needs.filter_jobs.outputs.jsChanged == 'true' &&
+      github.event.action == 'completed' &&
+      github.event.workflow_run.conclusion == 'success'
     steps:
       # Download the artifact from the triggering workflow that contains the
       # Tachometer results to report
       - uses: dawidd6/action-download-artifact@v2
         with:
           workflow: ${{ github.event.workflow.id }}
           run_id: ${{ github.event.workflow_run.id }}
-          name: results
+          name_is_regexp: true
+          name: results-*
           path: results
 
       # Create/update the comment with the latest results
       - name: Report Tachometer Results
         uses: andrewiggins/tachometer-reporter-action@v2
         with:
-          path: results/*.json
+          path: results/**/*.json
           base-bench-name: preact-main
           pr-bench-name: preact-local
-          summarize: 'duration, usedJSHeapSize'
+          summarize: 'duration, usedJSHeapSize'

.github/workflows/run-bench.yml

@@ -59,7 +59,7 @@ jobs:
             ${{ runner.os }}-pnpm-store-
 
       # Install benchmark dependencies
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: bench-environment
       - name: Move tarballs from env to correct location
@@ -107,15 +107,16 @@ jobs:
         id: log-artifact-name
         run: |
           NAME=$(echo "${{ inputs.benchmark }}" | sed -r 's/[\/]+/_/g')
+          echo "clean_name=$NAME" >> $GITHUB_OUTPUT
           echo "artifact_name=logs_$NAME" >> $GITHUB_OUTPUT
       - name: Upload results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: results
+          name: results-${{ steps.log-artifact-name.outputs.clean_name }}
           path: benchmarks/out/results/${{ inputs.benchmark }}.json
       - name: Upload logs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.log-artifact-name.outputs.artifact_name }}
           path: benchmarks/out/${{ inputs.benchmark }}_logs.tgz
-          if-no-files-found: ignore
+          if-no-files-found: ignore