Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Commit

Permalink
Add required code change for Renown Level 62. (#35)
Browse files Browse the repository at this point in the history
* Add required code change for Renown Level 62.
* Add to thanks section. :)
  • Loading branch information
FlipperPA authored Aug 20, 2021
1 parent 8f308d9 commit a0e0bc8
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,27 @@ In the US, see e.g. [Galoob v. Nintendo](https://www.lexisnexis.com/community/ca

# Getting it running

To expose VenturePlan's internal data you will need to edit its source code. Open up Interface/Addons/VenturePlan/vs.lua in a text editor, and insert the line `_G[_] = T` in the first blank space. It should look like this when you're done:
To expose VenturePlan's internal data you will need to edit its source code. First, ensure that you are on the latest version, `4.16a`. Then open up `_retail_/Interface/AddOns/VenturePlan/vs.lua` in a text editor, and insert the line `_G[_] = T` in the first blank space. It should look like this when you're done:

![Notepad preview of changed file](img/notepad.png)

This makes the internal data of the addon (`T`) available to other addons (by putting it in the global table, `_G`, which every addon has available to it). In general you shouldn't be messing with addons like this, because it's a great way of getting hacked, but in this case there's no way around it. _caveat emptor_

# Hotfixing the Code for Renown Level 62 and Above

At renown level 62, you will gain your 21st companion. VenturePlan is coded to handle a maximum to 20 companions. You will start seeing errors about `self.info` being `nil`. To fix this, edit the file `_retail_/Interface/AddOns/VenturePlan/Widgets.lua`: change line 1960 (in version `4.16a`) from `for i=1,20 do` to `for i=1,99 do`. This will add support up to 99 companions.

After completing this change, the code should look like this:

```lua
s.companions = {}
for i=1,99 do
t = CreateObject("FollowerListButton", f, false)
t:SetPoint("TOPLEFT", ((i-1)%4)*76+14, -math.floor((i-1)/4)*72-130)
s.companions[i] = t
end
```

# Contributing

If you have updates to the spell list you'd like to include (see `extra-vs-spells.lua`), please open a PR and I'll add them.
Expand All @@ -50,5 +65,7 @@ Many thanks to:
* epiktetov
* woefulwabbit
* boomboo

* FlipperPA
* cremor

for contributions and support, as well as to the original author for a great addon.

2 comments on commit a0e0bc8

@Konctantin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 99 better to use #CovenantMissionFrame.FollowerList.followersList in my opinion.
for i=1,#CovenantMissionFrame.FollowerList.followersList do

@siweia
Copy link

@siweia siweia commented on a0e0bc8 Aug 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Konctantin Follower buttons only created once you open the covanant table, if you use '#followerslist', the actual follower list won't update if you gain new followers after that.

Please sign in to comment.