-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardware cursor not showing on mirror displays #6523
Conversation
Hardware cursors were missing on mirrored monitors. This PR fixes that. Fixes hyprwm#6455
also maybe we should just lock software? this will break if the output mirroring is a different res |
How? I tried to account for that here: 3364e76#diff-649995ddb095587b539b1ea9cbe9bb01f749557ff5f34229f0688a276b957493R396 Tested on my system mirroring a 1440p screen to a 1080p monitor and it worked fine. |
what about different aspect ratios? What about stretching? Size? |
If you think that'd be solved by some transforms when handling pointer positions on |
I believe software cursors on mirrors are the way to go. |
Sure, I'll convert this to a draft if you don't mind because I'd still like to tackle it later |
1184395
to
b16fb97
Compare
Describe your PR, what does it fix/add?
Ensure cursor is rendered on mirror displays when using hardware cursor. (Fixes #6455 )
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
AFAIK this is a hack but works well on my system (using nvidia :)).
Is it ready for merging, or does it need work?
I guess it is, but again it's a hack so there could be tons of better solutions for this