Nix: remove HiDPI patches

[fufexan]

Describe your PR, what does it fix/add?

• remove hidpiXWayland option
• rename nvidiaPatches -> enableNvidiaPatches for consistency with enableXWayland
• Complements XWayland: remove HiDPI patches support hyprland-wiki#282.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Will need to be announced to the community when merged.

Is it ready for merging, or does it need work?

Ready.

[vaxerski]

reqs a wiki update ofc ass well

[q234rty]

they are deprecated because xwayland:force_zero_scaling does exactly the same with less hacks

Unfortunately, I believe xwayland:force_zero_scaling as it currently is does not support multi monitor with different scale factors, since X11 does not support them except maybe with Qt.

[MrDuartePT]

@fufexan since you seems to be the maintainer of the Nix package for Hyprland you can give a look at this PR: #2874.

Doesn't seems to break the Nix package but I don't use Nix to be sure.

[fufexan]

@q234rty as far as I know, the patches don't solve this issue either.

[q234rty]

@fufexan These patches partially mitigate this issue by letting the compositor do per-monitor downscaling, e.g. if one monitor is under 200% and another monitor is under 100%, Xwayland apps will see two 200% screens and the compositor will do the downscaling on the 100% monitor. This is of course not perfect but still much better than having very large Xwayland apps on the 100% monitor.

[fufexan]

@q234rty if the users desire that functionality, they can copy the code previous to these commits and override hyprland themselves. In the meantime, we will be waiting for an official solution.

[q234rty]

Whatever, I will just continue maintaining my AUR hyprland-hidpi-xprop-git package with the old approach :)

[vaxerski]

we are removing the patches because of my pressure to do so.

The approach is shit and buggy, requires patching which already is a pain, and xwayland:force_zero_scaling does exactly the same.

[q234rty]

and xwayland:force_zero_scaling does exactly the same.

As mentioned above, xwayland:force_zero_scaling does not handle multi monitor with different scale factors, so it does not "do exactly the same"

[vaxerski]

does it not? how so? it removes scaling.

[q234rty]

Yes, it removes scaling by the compositor, but no, X11 itself does not handle multi monitor with different scale factors, so letting X11 see the same scale factor across all monitors and letting the compositor do the downscaling is helpful, which is what the old approach did.

[spikespaz]

I left a many comments, most are nitpicks or questions. This looks good as it is. There are some suggestions that do not align with the description of the PR.