screencopy: wait longer to re-enable DS#12135
Conversation
29dbec0 to
b6a59b0
Compare
|
Idk what happened but applying these PRs (including this one) fixed the HDR screenshare being overly bright and having inaccurate colors for me.: Only issue left is I can't adjust brightness or saturation anymore with sdrsaturation and sdrbrightness or with any of the luminance settings. Note: I also updated my system recently but I doubt that's what caused it. Edit: Nvm HDR games like Marvel's Spider-Man 2 still look overly bright. Indiana Jones works fine though. |
|
@s0mebodyhelpme Thanks for testing! #12094 would be the big one for the results you described. I'll have to give it another look to see why the SDR settings broke. I used As for the screenshare brightness, I have some WIP changes locally to improve that, but I'd like to stop spamming changes and get the more significant stuff reviewed first. |
b6a59b0 to
4c1a33f
Compare
Describe your PR, what does it fix/add?
When screen-recording, DS constantly enables/disables between frames if the capture framerate is lower than the render framerate, causing frequent stutter (games) and modesets (VLC, non-shader CM). This change gives it some headroom before re-enabling DS.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Tested with games/VLC and capturing with
gpu-screen-recorderw/ pipewire capture, and OBS.Is it ready for merging, or does it need work?
Ready