syncobj: use rendernode for timelines#11087
Merged
Merged
Conversation
Member
|
might be affected by #11117 |
Contributor
Author
yeah moved the displaynode / rendernode to structs. check cap on display node first, then render node. unless i missed some logic here i think its working as intended |
|
Can confirm this PR (+ aquamarine changes) works for me on asahi |
Contributor
Author
nice, mostly just waiting for AQ release then and our rulers review on it ;) |
Member
|
needs a nix bump + cmake/meson aq dep bump and should be gtg |
Contributor
Author
nix i got no clue, i leave that for @fufexan |
Member
|
@fufexan can you bump aq again |
Contributor
Author
|
did that actually build with AQ git or did it just rebuild same 0.9.3? |
Contributor
Author
checked hashes, it did. nvm. |
gulafaran
force-pushed
the
rendernode
branch
3 times, most recently
from
712d43f to
43f67a2
Compare
Contributor
Author
|
@fufexan i assume its fine if i update the flake.lock? or does nixos need some prep outside of this flake? |
Member
|
Yeah, you can update it. No need for anything else. |
2 tasks
use rendernode for timelines instead of the drmfd, some devices dont support to use the drmfd for this.
use rendernode if available for CHyprOpenglImpl
try use the rendernode we got from AQ if it exist.
use the rendernode if available already from AQ
prefer the rendernode over the displaynode, and log a error if attempting to use the protocol without explicit sync support on any of the nodes.
check support on both nodes always so it can be used later for preferring rendernode if possible in syncobj protocol.
remove old m_bDrmSyncobjTimelineSupported from non linux if else case that will fail to compile on non linux. the nodes sets support by default to false, and if non linux it wont check for support and set it to true.
bump to 0.9.3 where rendernode support got added.
software renderers apparently bug out on implicit sync, use glfinish as with nvidia case on implicit paths.
vaxerski
approved these changes
Aug 24, 2025
|
Thanks a lot for the fix @gulafaran :) |
Boom-Hacker
pushed a commit
to Boom-Hacker/Hyprland
that referenced
this pull request
Sep 27, 2025
* syncobj: use rendernode for timelines use rendernode for timelines instead of the drmfd, some devices dont support to use the drmfd for this. * opengl: use rendernode if available use rendernode if available for CHyprOpenglImpl * MesaDRM: use the m_drmRenderNodeFD if it exist try use the rendernode we got from AQ if it exist. * linuxdmabuf: use rendernode if available use the rendernode if available already from AQ * syncobj: prefer rendernode over displaynode prefer the rendernode over the displaynode, and log a error if attempting to use the protocol without explicit sync support on any of the nodes. * syncobj: check support on both nodes always check support on both nodes always so it can be used later for preferring rendernode if possible in syncobj protocol. * syncobj: remove old var in non linux if else case remove old m_bDrmSyncobjTimelineSupported from non linux if else case that will fail to compile on non linux. the nodes sets support by default to false, and if non linux it wont check for support and set it to true. * build: bump aq requirement bump to 0.9.3 where rendernode support got added. * flake.lock: update * renderer: glfinish on software renderer software renderers apparently bug out on implicit sync, use glfinish as with nvidia case on implicit paths. * flake.lock: update --------- Co-authored-by: Mihai Fufezan <mihai@fufexan.net>
Boom-Hacker
pushed a commit
to Boom-Hacker/Hyprland
that referenced
this pull request
Sep 27, 2025
* syncobj: use rendernode for timelines use rendernode for timelines instead of the drmfd, some devices dont support to use the drmfd for this. * opengl: use rendernode if available use rendernode if available for CHyprOpenglImpl * MesaDRM: use the m_drmRenderNodeFD if it exist try use the rendernode we got from AQ if it exist. * linuxdmabuf: use rendernode if available use the rendernode if available already from AQ * syncobj: prefer rendernode over displaynode prefer the rendernode over the displaynode, and log a error if attempting to use the protocol without explicit sync support on any of the nodes. * syncobj: check support on both nodes always check support on both nodes always so it can be used later for preferring rendernode if possible in syncobj protocol. * syncobj: remove old var in non linux if else case remove old m_bDrmSyncobjTimelineSupported from non linux if else case that will fail to compile on non linux. the nodes sets support by default to false, and if non linux it wont check for support and set it to true. * build: bump aq requirement bump to 0.9.3 where rendernode support got added. * flake.lock: update * renderer: glfinish on software renderer software renderers apparently bug out on implicit sync, use glfinish as with nvidia case on implicit paths. * flake.lock: update --------- Co-authored-by: Mihai Fufezan <mihai@fufexan.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use rendernode for timelines instead of the drmfd, some devices dont support to use the drmfd for this.
requires: hyprwm/aquamarine#193
fixes: #10401