Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS / Tailwind configuration and build process #909

Merged
merged 2 commits into from
May 2, 2023

Conversation

robertknight
Copy link
Member

Depends on #908

Set up the CSS / Tailwind build. This largely follows the structure and config in the hypothesis/lms repo, with the LMS-specific Tailwind extensions removed.

],
theme: {
extend: {
fontFamily: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the font family stack here from the LMS app, as I didn't see a default in @hypothesis/frontend-shared/lib/tailwind.preset.js. I'm not sure that we want this here though. @lyzadanger can you advise when you're back from 🇧🇪 ?


@tailwind base;
@tailwind components;
@tailwind utilities;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry point is CSS rather than SASS for now. We can change this as and when we need SASS features.

Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Base automatically changed from video-player-lint to main May 2, 2023 12:52
Set up the CSS / Tailwind build. This largely follows the structure and config
in the hypothesis/lms repo, with the LMS-specific Tailwind extensions removed.
@robertknight robertknight merged commit fd7a6a0 into main May 2, 2023
@robertknight robertknight deleted the video-player-css branch May 2, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants