Add frontend test infrastructure for video player app #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2023
Merged
robertknight
force-pushed
the
video-player-tests
branch
from
1016ef7 to
00c049b
Compare
acelaya
approved these changes
May 2, 2023
Add frontend unit testing infrastructure using our standard stack (Karma, mocha, chai, sinon, Enzyme etc.) Some notes: - We don't have any CommonJS runtime dependencies, but some of our test deps are still CJS, so we still need Rollup's CJS plugin for those. - Tests produce a warning about a `build/styles/*.css` pattern in karma.config.js not matching any files. This is because the video player doesn't have any CSS yet. That will change soon. - The setup file for the test environment was named `setup-tests.js` in this project rather than `bootstrap.js` as in other projects. I feel that the bootstrap name is completely non-obvious and we should change it.
This is expected by the GitHub CI workflow I'm about to add. This project will have linting, I just haven't added it yet.
Copy frontend CI steps from GitHub CI workflows in the lms project.
robertknight
force-pushed
the
video-player-tests
branch
from
00c049b to
a903008
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #905
This PR adds our standard frontend testing infrastructure to Via for use with the video player app, and a simple test module (
HypothesisClient-test.js). It also adds a GitHub CI workflow to run the tests.The infrastructure is copied and tweaked from the lms repo, minus a few vestigial things I removed. One intentional change is that the file that sets up the global JS environment in the tests is called
setup-tests.jsin this repo, rather thanbootstrap.jsas in other repos. This seems like a much more obvious name to me.