Bump preact from 10.11.0 to 10.11.1 #661
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
Bumps [preact](https://github.com/preactjs/preact) from 10.11.0 to 10.11.1. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](preactjs/preact@10.11.0...10.11.1) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/preact-10.11.1
branch
from
7b39dd0
to
8cfcafb
Compare
Both Overlay and the HTML details element accept an `open` prop. This used to be `boolean|undefined` in both cases, so there was no conflict. In the latest Preact update however all HTML attributes have gained the ability to accept signals as well as raw values. This means the types of Overlay's `open` and JSX `open` no longer align.
Several components accepted arbitrary `<input>` props as props. The type for these props was specified as `JSX.HTMLAttributes<HTMLInputElement>`. TypeScript looks up the props using `JSX.IntrinsicElements[$tag_name]` [1]. For all element types other than `<input>`, these two types are the same. In the latest Preact update, `<input>` is a special snowflake and these two types have a different `defaultValue` attribute. [1] https://www.typescriptlang.org/docs/handbook/jsx.html#intrinsic-elements
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 631 631
Branches 226 226
=========================================
Hits 631 631
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I pushed a couple of changes to fix conflict with the latest Preact updates. The problems were related to a change to make almost all HTML attributes accept signals as well as raw values. This resulted in a conflict with the |
|
The issue with |
I think I'd prefer this (wait), as the type changes required to work around the current patch are rather inscrutable. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
The issue with |
Bumps preact from 10.11.0 to 10.11.1.
Release notes
Sourced from preact's releases.
Commits
b25fd03Merge pull request #3756 from preactjs/release-10.11.119374b3Release 10.11.1820bff3Merge pull request #3755 from akselander/chore/compat/add-package4362700refactor(curb): remove format specifiersb5d589cchore(compat): add package.json to exports284a8b0remove _nextDom resetting as it collides with nested fragment switching (#3738)d30a0edAvoid synchronously adding setState callbacks (#3743)dfd45aaMerge pull request #3747 from preactjs/signals-typeeeb5d6cSupport signal values for html + svg attributes32163d0Merge pull request #3741 from preactjs/bugfix-nested-unmountDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)