Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 3, 2025

Bumps preact from 10.26.0 to 10.26.4.

Release notes

Sourced from preact's releases.

10.26.4

Fixes

10.26.3

Fixes

Types

Maintenance

10.26.2

This is a hotfix release! If you are encountering bundling issues with regards to unallowed import syntax, this will fix it!

Fixes

Maintenance

10.26.1

Fixes

  • Fixes memory leak when wrapping Fragment is captured by an effect closure (#4680, thanks @​JoviDeCroock)

Optimization

Maintenance

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 3, 2025
Bumps [preact](https://github.com/preactjs/preact) from 10.26.0 to 10.26.4.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](preactjs/preact@10.26.0...10.26.4)

---
updated-dependencies:
- dependency-name: preact
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/preact-10.26.4 branch from 92d0514 to b0bb356 Compare March 10, 2025 13:08
@acelaya
Copy link
Contributor

acelaya commented Mar 24, 2025

@dependabot rebase

@robertknight
Copy link
Contributor

Typecheck error:

src/components/navigation/TabList.tsx:45:6 - error TS2322: Type '{ children: ComponentChildren; ref: Ref<HTMLDivElement> | undefined; className: string; role: "tablist"; "aria-orientation": "horizontal" | "vertical"; ... 297 more ...; "data-component": string; }' is not assignable to type 'HTMLAttributes<HTMLDivElement>'.
  Types of property 'onCommand' are incompatible.
    Type 'CommandEventHandler<HTMLElement> | undefined' is not assignable to type 'CommandEventHandler<HTMLDivElement> | undefined'.
      Type 'CommandEventHandler<HTMLElement>' is not assignable to type 'CommandEventHandler<HTMLDivElement> | undefined'.
        Type 'CommandEventHandler<HTMLElement>' is not assignable to type 'CommandEventHandler<HTMLDivElement>'.
          Type 'CommandEventHandler<HTMLElement>' is not assignable to type '{ readonly currentTarget: HTMLDivElement; }'.
            Types of property 'currentTarget' are incompatible.
              Property 'align' is missing in type 'HTMLElement' but required in type 'HTMLDivElement'.

align is a deprecated property on HTMLDivElement.

@robertknight
Copy link
Contributor

robertknight commented Mar 31, 2025

The relevant upstream change is preactjs/preact#4692.

@robertknight robertknight self-assigned this Mar 31, 2025
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d558251) to head (22a02d3).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1899   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           70        70           
  Lines         1316      1318    +2     
  Branches       486       486           
=========================================
+ Hits          1316      1318    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertknight robertknight force-pushed the dependabot/npm_and_yarn/preact-10.26.4 branch from 22a02d3 to b0bb356 Compare March 31, 2025 08:05
@robertknight
Copy link
Contributor

There is a mistake in Preact's jsx.d.ts file:

	export type ClipboardEventHandler<Target extends EventTarget> = EventHandler<
		TargetedClipboardEvent<Target>
	>;
	export type CommandEventHandler<Target extends EventTarget> =
		TargetedCommandEvent<Target>
	export type CompositionEventHandler<Target extends EventTarget> =
		EventHandler<TargetedCompositionEvent<Target>>;

The newly added CommandEventHandler type has a different structure than the other handlers. It is missing the EventHandler wrapper.

@robertknight
Copy link
Contributor

Upstream PR: preactjs/preact#4740

rschristian pushed a commit to preactjs/preact that referenced this pull request Mar 31, 2025
Update the `CommandEventHandler` type declaration to match other `*EventHandler`
types by using the `EventHandler` utility. This fixes a downstream typing error
reported in
hypothesis/frontend-shared#1899 (comment).
@robertknight
Copy link
Contributor

Upstream PR has been merged. This will be fixed in the next Preact update, so I will close this and wait for Dependabot to notify us when that becomes available.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 31, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/preact-10.26.4 branch March 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants