Tabs to spaces pr 873 #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex was too greedy, matched last instance of what looks like an edition isntead of the first.
fix Switch/Case -> switch/case
fix missing parens.
fix scope issue.
Zap all tabs to spaces and eliminate extra spaces at end of lines for entire codebase. Other outstanding PR will be converted also.
…enetURI supports that already
The Java 8 Date-Time APIs provide superior alternatives for the methods provided in this class.
Only get() and getInMillis() were used within Fred. These methods can trivially be replaced by new Date() and System.currentTimeMillis() respectively.
Also remove unused private field with type Random from DatabaseKey class. Remove some unused methods from tests. Signed-off-by: Veniamin Fernandes <[email protected]>
Also removes stacktrace printout and exception suppression. This slightly changes behavior, but exceptions are not silenced anymore.
Note: I changed only places mentioned in the review comments. Some better and massive tabs-vs-spaces fix is required to solve all other issues.
…gnature Checked UnsupportedEncodingException cannot be removed because of backward compatibility.
As stated in the description of this option, if a large portion of the network disables packet padding it makes the network easier to trace. 15 years later now, if network overhead is a real concern for some users they can tweak this themselves.
In UdpSocketHandler.innerCalculateMaxPacketSize() the lesser of the configurable variable node.maxPacketSize and UdpSocketHandler.MAX_ALLOWED_MTU is used, the latter of which was hard coded to 1280.
We are actually checking if the string is empty. Using .isEmpty() is clearer.
In the profiling with jvisualvm this reduces the total time for MessageFilter::match from 5x the self-time to about 1.2x the self-time In profiling with instrumentation, MessageFilter::match is the most expensive method call, because it is called millions of times in a tight inner loop while handling messages.
Match is called so often, that the match-method with two arguments took 20% of the self-time of the match-method with three arguments. This may be inflated due to the instrumentation, though, because the method with two arguments does nothing except for running the method with three arguments with the default (false), so I expect less than those 20% in wins.
To evaluate the logs this produces: grep -Eo or-match.* ~/Freenet/logs/freenet-latest.log | \ sort | uniq -c | sort -h \ > misordered-MessageFilter-or-matches.log cat misordered-MessageFilter-or-matches.log this produces a list of MessageFilters with the frequency for pairs where the first is the one that did not match and the second is the filter that did match.
…ng code." This reverts commit eaed0f3.
With the decision by OLG Köln from 2023-11 https://www.heise.de/news/Oberlandesgericht-Cloudflare-haftet-als-Taeter-fuer-Urheberrechtsverletzungen-9355760.html caching services must stop access quickly when they get a report. Therefore linking directly to an index becomes too risky: we’ll have link them only via the Index of Indexes so we can remove the link to the index quickly if an index fails to react to a report in time.
(bug reported by oishii@e-FUmCyxfF9D… on FMS)
There were no restraints on negative values or extremely large values of amountOfDataToCheckCompressionRatio. Add a less than zero and a max of 100 MiB check.
amountOfDataToCheckCompressionRatio log message was hard to read
It changed more than needed.
Zap all tabs to spaces and eliminate extra spaces at end of lines for entire codebase. Other outstanding PR will be converted also.
…aster-PR-tabs-to-spaces
Zap all tabs to spaces and eliminate extra spaces at end of lines for outstanding PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.