Conversation
ArneBab
left a comment
There was a problem hiding this comment.
would be great to harmonize object-position and background-position, and object-position and rotate need some tests that illegal values are rejected.
|
Thank you for the PR! These look pretty useful for freesite authors! (and for being able to simply mirror arbitrary pages) |
|
Sorry, closed in error (I only wanted to comment but hit the wrong button). |
ArneBab
left a comment
There was a problem hiding this comment.
looks good to me — thank you!
|
Should I continue updating more CSS properties here or should I create new branches? |
…line)-(start,end),(min,max)-(width,height,block-size,inline-size)
…ck,inline)-(start,end)
|
58 properties supported in this pull request:
132 currently still not supported new CSS properties:
31 currently supported non-standard or deprecated CSS properties needing review:
|
|
Normally I’d say "please create new branches if a PR is already approved" (I go through the PRs every few weekends and merge what’s approved, so if you add another commit after approval, I cannot merge the PR), but if the commits are obviously correct, I’ll review them by commit. |
ArneBab
left a comment
There was a problem hiding this comment.
Change needed: 1e6c4bd#r2072343365
|
I now reviewed all the commits — that’s great work! Thank you! Can you address the three points? Then I can merge this. If you manage to finish updating the filter, I’d guess that there’ll then be few people with a similarly complete knowledge about available CSS options as you’ll then have … |
|
Thank you. I guess I am gonna watch videos now, 58 new CSS properties might be too many for a single PR! |
|
Taking a break is important ☺ |
Add CSS properties isolation,object-position,pointer-events,rotate,row-gap