Add dismiss all alerts and delete all messages buttons.#1046
Merged
ArneBab merged 6 commits intohyphanet:nextfrom Jun 28, 2025
Merged
Add dismiss all alerts and delete all messages buttons.#1046ArneBab merged 6 commits intohyphanet:nextfrom
ArneBab merged 6 commits intohyphanet:nextfrom
Conversation
62ebf44 to
9f77b50
Compare
Bombe
requested changes
Jun 27, 2025
src/freenet/node/useralerts/AbstractNodeToNodeFileOfferUserAlert.java
Outdated
Show resolved
Hide resolved
Comment on lines
+78
to
+86
| for (UserAlert alert : ctx.getAlertManager().getAlerts()) { | ||
| if (!alert.userCanDismiss()) { | ||
| continue; | ||
| } | ||
| if (alert instanceof NodeToNodeMessageUserAlert) { | ||
| continue; // keep all node to node messages | ||
| } | ||
| ctx.getAlertManager().dismissAlert(alert.hashCode()); | ||
| } |
Contributor
There was a problem hiding this comment.
(Sorry for shaving this yak, feel free to ignore, but if you don’t ignore it, make sure I got it right, negations are confusing. 😄)
Suggested change
| for (UserAlert alert : ctx.getAlertManager().getAlerts()) { | |
| if (!alert.userCanDismiss()) { | |
| continue; | |
| } | |
| if (alert instanceof NodeToNodeMessageUserAlert) { | |
| continue; // keep all node to node messages | |
| } | |
| ctx.getAlertManager().dismissAlert(alert.hashCode()); | |
| } | |
| Arrays.stream(ctx.getAlertManager().getAlerts()) | |
| .filter(UserAlert::userCanDismiss) | |
| .filter(alert -> !(alert instanceof NodeToNodeMessageUserAlert)) | |
| .map(Object::hashCode) | |
| .forEach(ctx.getAlertManager()::dismissAlert); |
Comment on lines
+90
to
+101
| for (UserAlert alert : ctx.getAlertManager().getAlerts()) { | ||
| if (!(alert instanceof NodeToNodeMessageUserAlert)) { | ||
| continue; | ||
| } | ||
| if (alert instanceof AbstractNodeToNodeFileOfferUserAlert) { | ||
| continue; // not deleting file offers, because these need a decision | ||
| } | ||
| if (!alert.userCanDismiss()) { | ||
| continue; | ||
| } | ||
| ctx.getAlertManager().dismissAlert(alert.hashCode()); | ||
| } |
Contributor
There was a problem hiding this comment.
(More yak shaving.)
Suggested change
| for (UserAlert alert : ctx.getAlertManager().getAlerts()) { | |
| if (!(alert instanceof NodeToNodeMessageUserAlert)) { | |
| continue; | |
| } | |
| if (alert instanceof AbstractNodeToNodeFileOfferUserAlert) { | |
| continue; // not deleting file offers, because these need a decision | |
| } | |
| if (!alert.userCanDismiss()) { | |
| continue; | |
| } | |
| ctx.getAlertManager().dismissAlert(alert.hashCode()); | |
| } | |
| Arrays.stream(ctx.getAlertManager().getAlerts()) | |
| .filter(NodeToNodeMessageUserAlert.class::isInstance) | |
| .filter(alert -> !(alert instanceof AbstractNodeToNodeFileOfferUserAlert)) | |
| .filter(UserAlert::userCanDismiss) | |
| .map(Object::hashCode) | |
| .forEach(ctx.getAlertManager()::dismissAlert); |
Bombe
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.