Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Swap positions of the filter button and the new proposal button #334

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

nbetsaif
Copy link
Collaborator

Swap positions of the New Proposal button and the Filter button, with additional UI adjustments.

Screenshots

Image 2

@nbetsaif nbetsaif requested a review from n13 September 30, 2024 10:12
@nbetsaif nbetsaif self-assigned this Sep 30, 2024
@nbetsaif nbetsaif linked an issue Sep 30, 2024 that may be closed by this pull request
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little odd to have naked magic numbers in a layout - but maybe in this case needed?

@nbetsaif
Copy link
Collaborator Author

nbetsaif commented Oct 1, 2024

@n13 Could you clarify what you mean by "odd magic numbers" in this context? In this PR, I only swapped the positions of the two buttons, and no specific numbers were added or modified.

@nbetsaif nbetsaif merged commit 87e72e7 into main Oct 1, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap the Filter and New Proposal Icons
2 participants