fix: set AppBar scrolledUnderElevation to 0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
approved these changes
Aug 30, 2024
Zied-Dahmani
deleted the
bugfix/transaction_details_view_app_bar_elevation
branch
The color change behavior of the AppBar in Flutter's Material 3 (M3) design system is not necessarily a bug but rather a design choice aligned with Material Design guidelines. However, this behavior can become an "issue" if it conflicts with the developer's or designer's vision for the app. This is especially noticeable in light mode, where the color change may not always lead to a visually appealing appearance. |
|
Alright I didn't check light mode - On Aug 31, 2024, at 08:18, Zied Dahmani ***@***.***> wrote:
Approved.
I am not 100% sure if app bar isn't supposed to change color but no strong opinion on it.
The color change behavior of the AppBar in Flutter's Material 3 (M3) design system is not necessarily a bug but rather a design choice aligned with Material Design guidelines. However, this behavior can become an "issue" if it conflicts with the developer's or designer's vision for the app. This is especially noticeable in light mode, where the color change may not always lead to a visually appealing appearance.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Zied-Dahmani
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Ticket
I fixed the issue by setting
scrolledUnderElevationto0, which prevents theAppBarcolor from changing when scrolling on the transaction details page.Screenshots