Allow disabling of drag-based selection #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a use case where we need to prevent the user from dragging to select a date range. This `dragSelectionEnabled` property, which is true by default, determines whether to allow drag-based selection.
mkg0
requested changes
May 24, 2018
demo/src/components/Main.js
Outdated
| @@ -165,6 +165,7 @@ export default class Main extends Component { | |||
| months={2} | |||
| ranges={[this.state.dateRangePicker.selection]} | |||
| direction="horizontal" | |||
| dragSelectionEnabled={false} | |||
There was a problem hiding this comment.
It's better to show drag selection at examples. Can you remove it
There was a problem hiding this comment.
Yep sorry for that - used during testing and accidentally committed. Removing!
src/components/Calendar.js
Outdated
| disablePreview: true, | ||
| }, | ||
| }); | ||
| if (this.props.dragSelectionEnabled) { |
There was a problem hiding this comment.
there is no need to wrap whole func with if condition again. You can add an or to L314
if (!drag.status || !this.props.dragSelectionEnabled) return;
src/components/Calendar.js
Outdated
| onDragSelectionEnd(date) { | ||
| const { updateRange, displayMode, onChange, dragSelectionEnabled } = this.props; | ||
|
|
||
| if (dragSelectionEnabled) { |
There was a problem hiding this comment.
there is no need to wrap whole func with if condition:
if (!dragSelectionEnabled) return;
|
Can you add it on readme too? |
I used the "drag n drop" terminology from the top of the page, but feel free to change it if needed.
mkg0
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyDescription
We have a use case where we need to prevent the user from dragging to select a date range. This
dragSelectionEnabledproperty, which is true by default, determines whether to allow drag-based selection.