Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests of BrotliDecoderChannel #147

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jul 17, 2024

Motivation:

Noticed there were no tests for BrotliDecoderChannel, so here are a few for you to add.

Modification:

Created test cases for BrotliDecoderChannel.

Result:

See test cases

@hyperxpro
Copy link
Owner

Let me know if you want me to cut a release.

@joakime
Copy link
Contributor Author

joakime commented Jul 17, 2024

Let me know if you want me to cut a release.

Still working on the basics of integration on my side.
If you want to cut a release in the next month or two for your own reasons, don't let me stop you.

There's no rush for a release of brotli4j from me (yet).

@hyperxpro
Copy link
Owner

I don't have any release timeline but I'd help in every possible way to help in your integration in Jetty. :)

Btw, is the PR up?

@hyperxpro hyperxpro merged commit 2eddacf into hyperxpro:main Jul 17, 2024
27 checks passed
@hyperxpro
Copy link
Owner

Thanks a lot!

@joakime joakime deleted the tests/one_byte_at_a_time_decode branch July 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants