-
Notifications
You must be signed in to change notification settings - Fork 11
DTPOMERSER-1275 - iOS UI SDK - Create Transfer Method: List default currency per selected country #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akalichety-hw
merged 10 commits into
master
from
feature/DTPOMERSER-1275_Display_default_currency_if_exists
Feb 12, 2025
Merged
DTPOMERSER-1275 - iOS UI SDK - Create Transfer Method: List default currency per selected country #385
akalichety-hw
merged 10 commits into
master
from
feature/DTPOMERSER-1275_Display_default_currency_if_exists
Feb 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
select default currency code.
Used existing Locale for error message.
Collaborator
Author
Collaborator
Author
Collaborator
grmeyer-hw-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this test AddTransferMethodPresenterTests.testLoadTransferMethodConfigurationFields_failure ? it's failing
Used that method in already existing method to avoid if and else conditions.
grmeyer-hw-dev
approved these changes
Feb 12, 2025
Collaborator
grmeyer-hw-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work !!!
fzhang4-hw
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Ticket DTPOMERSER-1275
Changes
Tests
select_default_currency.mp4
Dependency