Skip to content

trino request handler fix for exception message length #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satish-mittal merged 5 commits into from
Oct 26, 2023
Merged

trino request handler fix for exception message length #211

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b16de64
truncate Trino query error message to 2K
satish-mittal Oct 25, 2023
66bf069
fix vulnerabilities
satish-mittal Oct 25, 2023
ee4bd85
handle indexOutOfBoundsException
satish-mittal Oct 25, 2023
22a9f2d
Merge branch 'main' into trino_exception_truncate
satish-mittal Oct 25, 2023
cb03283
use StringUtils
satish-mittal Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...-impl/src/main/java/org/hypertrace/core/query/service/trino/TrinoBasedRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ public Observable<Row> handleRequest(QueryRequest request, ExecutionContext exec

return executeQuery(sql.getKey(), sql.getValue());
} catch (Throwable t) {
String truncatedMessage = (t.getMessage() == null) ? null : t.getMessage().substring(0, 2048);
return Observable.error(new Throwable(truncatedMessage));
return Observable.error(new Throwable(truncateMessage(t.getMessage(), 2048)));
}
}

Expand Down Expand Up @@ -229,4 +228,12 @@ private Value getNullValueEquivalent(int columnType) {
return NULL_STRING_EQ_STRING_VALUE;
}
}

private String truncateMessage(String message, int length) {
if (message == null) {
return null;
} else {
return message.length() <= length ? message : message.substring(0, length);
}
}
}