Skip to content

chore: added array column tests in pinot #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kotharironak wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: added array column tests in pinot #209

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a12ed72
chore: added array column tests in pinot
kotharironak Oct 25, 2023
0e6d245
chore: adding test for not in filter
kotharironak Oct 25, 2023
df6749c
Merge branch 'main' into add-array-in-filter-pinot
kotharironak Oct 25, 2023
807badf
fixed the spotless issue
kotharironak Oct 26, 2023
138fdd6
Merge remote-tracking branch 'origin/main' into add-array-in-filter-p…
kotharironak Oct 26, 2023
bc412e7
Merge remote-tracking branch 'origin/add-array-in-filter-pinot' into …
kotharironak Oct 26, 2023
2c8c0e9
chore: added test for conversion of time series query
kotharironak Oct 26, 2023
1bdd2e9
Merge branch 'main' into add-array-in-filter-pinot
kotharironak Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions ...est/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createEqualsFilter;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createFunctionExpression;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createInFilter;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createNotInFilter;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createLongLiteralValueExpression;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createNotEqualsFilter;
import static org.hypertrace.core.query.service.QueryRequestBuilderUtils.createNullNumberLiteralValueExpression;
Expand Down Expand Up @@ -539,6 +540,58 @@ public void testSQLiWithBooleanArrayFilter() {
executionContext);
}

@Test
void testQueryWithArrayColumnInFilter() {
Builder builder = QueryRequest.newBuilder();
builder.addSelection(createColumnExpression("Span.id").build());

Filter filter = createInFilter("Span.ip_types", List.of("Public Proxy", "Bot"));
builder.setFilter(filter);
builder.setLimit(5);

QueryRequest request = builder.build();
ViewDefinition viewDefinition = getDefaultViewDefinition();
defaultMockingForExecutionContext();

assertPQLQuery(
request,
"select span_id from spaneventview "
+ "WHERE "
+ viewDefinition.getTenantIdColumn()
+ " = '"
+ TENANT_ID
+ "' "
+ "and ip_types in ('public proxy', 'bot') limit 5",
viewDefinition,
executionContext);
}

@Test
void testQueryWithArrayColumnNotInFilter() {
Builder builder = QueryRequest.newBuilder();
builder.addSelection(createColumnExpression("Span.id").build());

Filter filter = createNotInFilter("Span.ip_types", List.of("Public Proxy", "Bot"));
builder.setFilter(filter);
builder.setLimit(5);

QueryRequest request = builder.build();
ViewDefinition viewDefinition = getDefaultViewDefinition();
defaultMockingForExecutionContext();

assertPQLQuery(
request,
"select span_id from spaneventview "
+ "WHERE "
+ viewDefinition.getTenantIdColumn()
+ " = '"
+ TENANT_ID
+ "' "
+ "and ip_types not in ('public proxy', 'bot') limit 5",
viewDefinition,
executionContext);
}

@Test
public void testQueryWithLikeOperator() {
Builder builder = QueryRequest.newBuilder();
Expand Down
4 changes: 3 additions & 1 deletion query-service-impl/src/test/resources/request_handler.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
mapFields = ["tags", "request_headers"]
bytesFields = ["parent_span_id", "span_id"]
textIndexes = ["span_name"]
arrayFields = ["ip_types"]
fieldMap = {
"Span.tags": "tags",
"Span.id": "span_id",
Expand All @@ -24,7 +25,8 @@
"Span.attributes.response_body": "response_body",
"Span.metrics.duration_millis": "duration_millis",
"Span.serviceName": "service_name",
"Span.attributes.parent_span_id": "parent_span_id"
"Span.attributes.parent_span_id": "parent_span_id",
"Span.ip_types": "ip_types"
}
}
}
Expand Down