Skip to content

fix: wrong tooltip in radar chart in firefox #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021
Merged

fix: wrong tooltip in radar chart in firefox #990

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7960df
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 14, 2021
80139ba
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 15, 2021
5e09363
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 15, 2021
6ad2880
Merge branch 'main' into radar_chart_tooltip
aaron-steinfeld Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class RadialDataLookupStrategy {

public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) {
this.radialBisector = bisector(axisData => axisData.axisRadian);
this.radialAxisData = clone(radialAxisData);
this.radialAxisData = clone(radialAxisData.sort(axisData => axisData.axisRadian));
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort the cloned array instead of the argument

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, if this data is not sorted why is this not an issue in other browsers?

Copy link
Contributor Author

@jyothishjose6190 jyothishjose6190 Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sorted in other browsers like chrome and safari.
Without the fix, in chrome radialAxisData, is sorted by axisRadian
Screenshot 2021-07-15 at 10 51 29 AM

The same code in firefox returns radialAxisData is not sorted
Screenshot 2021-07-15 at 10 52 19 AM

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh strange - thanks for explaining!

this.addCyclicRedundancy();
}

Expand Down