Skip to content

fix: wrong tooltip in radar chart in firefox #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2021
Merged

fix: wrong tooltip in radar chart in firefox #990

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7960df
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 14, 2021
80139ba
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 15, 2021
5e09363
fix: wrong tooltip in radar chart in firefox
jyothishjose6190 Jul 15, 2021
6ad2880
Merge branch 'main' into radar_chart_tooltip
aaron-steinfeld Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class RadialDataLookupStrategy {
public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) {
this.radialBisector = bisector(axisData => axisData.axisRadian);
this.radialAxisData = clone(radialAxisData);
this.radialAxisData = this.radialAxisData.sort(axisData => axisData.axisRadian);
this.addCyclicRedundancy();
}

Expand All @@ -41,6 +42,7 @@ export class RadialDataLookupStrategy {
const leftValue = this.radialAxisData[insertionIndex - 1] as RadarAxisData | undefined;
const rightValue = this.radialAxisData[insertionIndex] as RadarAxisData | undefined;


if (leftValue === undefined) {
// No values to the left. Target is smallest value.
return rightValue;
Expand Down