Skip to content

Conversation

@palbizu
Copy link
Contributor

@palbizu palbizu commented Jun 10, 2021

Description

  • Updating styles of checkbox disabled
  • Adjusting background color in the checkbox (same as radio buttons)

Testing

Old:

image

New:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner June 10, 2021 23:13
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #922 (9172117) into main (7343dec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         803      803           
  Lines       16509    16509           
  Branches     2074     2074           
=======================================
  Hits        14090    14090           
  Misses       2387     2387           
  Partials       32       32           
Impacted Files Coverage Δ
...ects/components/src/checkbox/checkbox.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7343dec...9172117. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 83db9d9 into main Jun 10, 2021
@palbizu palbizu deleted the DisablingCheckbox branch June 10, 2021 23:21
@github-actions
Copy link

Unit Test Results

    4 files  ±0  257 suites  ±0   16m 50s ⏱️ +31s
926 tests ±0  926 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
932 runs  ±0  932 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 83db9d9. ± Comparison against base commit 7343dec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants