Skip to content

feat: add filled check circle icon and larger icon size #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2021
Merged

feat: add filled check circle icon and larger icon size #920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9565b0
feat: add filled check circle icon and larger icon size
jake-bassett Jun 9, 2021
619b57a
Merge branch 'main' into circle-icon-and-larger-size
jake-bassett Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/assets-library/assets/icons/check-circle-fill.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-library.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const iconsRootPath = 'assets/icons';
{ key: IconType.ArrowUpLeft, url: `${iconsRootPath}/arrow-up-left.svg` },
{ key: IconType.ArrowUpRight, url: `${iconsRootPath}/arrow-up-right.svg` },
{ key: IconType.CheckCircle, url: `${iconsRootPath}/check-circle.svg` },
{ key: IconType.CheckCircleFill, url: `${iconsRootPath}/check-circle-fill.svg` },
{ key: IconType.ChevronDown, url: `${iconsRootPath}/chevron-down.svg` },
{ key: IconType.ChevronLeft, url: `${iconsRootPath}/chevron-left.svg` },
{ key: IconType.ChevronRight, url: `${iconsRootPath}/chevron-right.svg` },
Expand Down
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const enum IconType {
ArrowUpRight = 'svg:arrow-up-right',
Cancel = 'cancel',
CheckCircle = 'svg:check-circle',
CheckCircleFill = 'svg:check-circle-fill',
Checkmark = 'checkmark',
ChevronDown = 'svg:chevron-down',
ChevronLeft = 'svg:chevron-left',
Expand Down
1 change: 1 addition & 0 deletions projects/components/src/icon/icon-size.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export const enum IconSize {
Medium = 'medium',
Large = 'large',
ExtraLarge = 'extra-large',
ExtraLarger = 'extra-larger',
Copy link
Contributor

@anandtiwary anandtiwary Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need better names

Copy link
Contributor Author

@jake-bassett jake-bassett Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and here I was hoping to squeeze in an ExtraMoreLargerest at some point.

Hodor = 'hodor',
Inherit = 'inherit'
}
6 changes: 6 additions & 0 deletions projects/components/src/icon/icon.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@
width: 32px;
}

&.extra-larger {
font-size: 48px;
height: 48px;
width: 48px;
}

&.hodor {
font-size: 64px;
height: 64px;
Expand Down