Skip to content

feat: table cell no-op parser update #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2021
Merged

feat: table cell no-op parser update #876

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcfe2ca
feat: table cell no-op parser update
May 24, 2021
ef2e482
feat: remove unused expressions
May 24, 2021
9c5c0d8
feat: adding comment to omit line
May 24, 2021
ccfd2af
feat: adding comment to omit line
May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions projects/components/src/table/cells/data-parsers/table-cell-no-op-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import { Dictionary } from '@hypertrace/common';
import { TableCellParser } from '../table-cell-parser';
import { TableCellParserBase } from '../table-cell-parser-base';
import { CoreTableCellParserType } from '../types/core-table-cell-parser-type';

@TableCellParser({
type: CoreTableCellParserType.NoOp
})
export class TableCellNoOpParser extends TableCellParserBase<unknown, unknown, string | undefined> {
public parseValue(cellData: unknown): unknown {
export class TableCellNoOpParser<T = unknown> extends TableCellParserBase<T, T, string | undefined> {
public parseValue(cellData: T): T {
return cellData;
}

public parseFilterValue(cellData: unknown): string | undefined {
public parseFilterValue(cellData: T | { filterValue?: string }): string | undefined {
// tslint:disable-next-line:strict-type-predicates
if (typeof cellData === 'object' && cellData !== null && 'filterValue' in cellData) {
return (cellData as Dictionary<unknown>).filterValue as string;
return cellData.filterValue;
}

return String(cellData);
Expand Down