fix: bad terrible awful totally unacceptable way of returning from method #829
Conversation
|
|
||
| public onSelectChange(changed: TableSelectChange): void { | ||
| if (changed.values.length === 0) { | ||
| // tslint:disable-next-line: no-void-expression |
There was a problem hiding this comment.
Am i the only one not liking this? :P
There was a problem hiding this comment.
Nah, I actually was on the fence before and totally agree with you now. I'm just teasing because it was still very much in 'nit' territory. 😝
There was a problem hiding this comment.
I am surprised Aaron has nothing to say on this
There was a problem hiding this comment.
I do my best to stay out of PRs! but I saw fun comments, so I did look: #823 (comment)
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
==========================================
- Coverage 85.42% 85.42% -0.01%
==========================================
Files 793 793
Lines 16230 16231 +1
Branches 1930 1930
==========================================
Hits 13865 13865
- Misses 2333 2334 +1
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Description
Bad Jake. Bad!